Can't get body from simplest email about mail-mime-parser HOT 9 CLOSED

Hi @postme --

I've release 0.4.3 for this.

Thanks,
Zaahid

from mail-mime-parser.

Nope, this turned out to be completely my fault, I had a shameful bug, I fixed it and all testcases now run without issue, yay!

from mail-mime-parser.

@postme can you add a failing test for your message?

from mail-mime-parser.

@zbateson What do you mean exactly with a failing test?

from mail-mime-parser.

Adding content-type: text/plain to the header resolves the issue, so it looks like getTextContent() gets thrown ofcourse if there's an email with a text/plain body but without a content-type declaration in the header.

Date: Fri, 10 Jul 2016 15:29:52 GMT
From: "Test Sender" <[email protected]>
To: "Test Recipient" <[email protected]>
Message-ID: <[email protected]>
Subject: [36]-text-plain-ipad
MIME-Version: 1.0
X-Mailer: iPad Mail (12H143)
Content-Type: text/plain

Test

No problems with this version.

from mail-mime-parser.

Hi @postme,

The failling test question was from @mstaack :) loving the involvement!

Unfortunately because of this I'm going to announce 0.4.2 as dead. My new PartFilter class didn't account for header defaults, and I'm rushing in a fix now and looking at how best to resolve it with versioning/composer.

Thanks,
Zaahid

from mail-mime-parser.

Ok everythings back to usual, the testcase is parsing as usual and applemail testcase for multiple html bodies is failing as expected.

from mail-mime-parser.

😢 it shouldn't fail though I even have test cases that should match what you're trying to do...

I still have the apple mail in question, but can you share the calls you're making to remove the html parts and tell me how it's failing (again)?

So sorry this one's dragging on so long for you!

from mail-mime-parser.

Aaah, I'm so happy to hear that 😄

from mail-mime-parser.