Improve Dialog Titles about zaproxy HOT 8 OPEN

@vl-gx you selected that you'd like to help. Shall we assign the issue to you?

Yes, but other people can participate. I may have not spoted every flawed window myself.

from zaproxy.

@vl-gx you selected that you'd like to help. Shall we assign the issue to you?

from zaproxy.

For the core: WritableFileChooser could be updated with constructors that accept a title and use setDialogTitle(String). Same for ReadableFileChooser in commonlib.

That'll make things easier for add-ons like exim (HAR Import, etc).

from zaproxy.

How does it make easier? They can just call the setter (like they do for other things).

from zaproxy.

It makes it easier for us to find the other constructors - if we always use the new ones then we can spot the ones that dont use them much more easily 😁

from zaproxy.

It's also a single call for the implementer.

from zaproxy.

#8347 (comment)

There are ~12 usages of WritableFileChooser (in zap-extensions), not sure why shouldn't we just update all to set the title now (rather than wait for next version).

#8347 (comment)

So we should add a constructor(s) to replace all these calls too?
https://github.com/zaproxy/zap-extensions/blob/a1978aa3a7b42549c044317a9b85c76fe996236c/addOns/exim/src/main/java/org/zaproxy/addon/exim/PopupMenuExportUrls.java#L179-L181

Anyway, better add the class (and constructor) to commonlib than keep dragging the core class.

from zaproxy.

Sure we can go ahead and use setDialogTitle directly for now and not wait for core/commonlib. I was just trying to make it more future friendly. As for the file filters I guess we could make a constructor with vargs or a list for that as well 🤷‍♂️

I just figured if there's a constructor that makes it easy for devs to use then we're less likely to have to revisit this in the future. I'm not meaning to over think it or make work. I'm fine whichever way it goes.

from zaproxy.