DND in breaks on large numbers. about baseconverter HOT 7 CLOSED

Thanks for the help!

from baseconverter.

from baseconverter.

Thank you for your help! Looking forward to a pr.
…
-Zach
On Tue, Jun 28, 2022 at 10:23 AM yaki3355 @.> wrote: Hi, ignore my pr not working for 20202020202020202020202020202020 — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH5SRPVK2AR5IKJMKS4EKLVRMRIZANCNFSM5Z6YDTWQ . You are receiving this because you authored the thread.Message ID: @.>

Hey @zamicol
#14 is waiting for merge

from baseconverter.

BigInt's still has a max size. On my browser that limit appears to be 1024 bits. I think we might need to use something like https://github.com/Yaffle/BigInteger for integers of arbitrary size.

There might be better ways to write it as well. One of the considerations was substitution of the input string into characters so that the main conversion algorithm could be employed. Since Javascript is UTF-16, that's enough space for dice of very many sides.

For now, 1024 is good enough! If we decided to revisit this in the future I wanted to keep some notes.

from baseconverter.

I'm reopening this issue because it appears to be broken?

https://convert.zamicol.com/#?inAlph=Hex&in=2BA34AED308AEA3427915F3E81887BC72CF5B5EA50AA89682052977C3773B925&outAlph=DND:20

Flip in and out, output is not the same.

from baseconverter.

Appears to be something with decimal: #?inAlph=0123456789&in=19737965684488488330219457478821781329850879392429569589875235152337186062336&outAlph=Hex

from baseconverter.

Fixed with latest push. 54b8503

https://convert.zamicol.com/#?inAlph=0123456789ABCDEF&outAlph=DND:16&in=FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

from baseconverter.