Add database column to Performance Analyses views about pgobserver HOT 6 CLOSED

@rippiedoos hi, just and update - there's already a PR waiting (#71) to be reviewed by one of my colleagues :)

from pgobserver.

Ok yes, would make sense. Issue didn't pop up in our environment because we create separate service names (IPs) for every database, even if they're on the same cluster. Will attack it soon:)

from pgobserver.

I figured something like that was the reason for the current setup. I tried to change the templates and code my self to create a pull request, but after looking at it for 2 hours and going over the different parts of the code it was too much work. I thought I would need to change half of the code because everything is referencing a host. And changing that to host_ui_shortname would not only mean changing methods and templates but also changing queries, api and other parts as well and a lot of testing.

So we created for every database a hosts-file-entry to make the current setup work. It would still be nice to have this implemented but at the moment we switched to services for databases as well. Kind of.

Thanks for the reply!

from pgobserver.

@kmoppel That's a substantial PR and looks very promissing! I thank you very much for that! I will install it on our system as soon as I have time for it.

I was heading the same way with my own changes but couldn't get near as close as you did. Also nice to see that you guys react really well to input from others. Thumbs up!!

from pgobserver.

Merged. Sorry, merge took some time :) NB! As the commit message says - a schema migration script from "sql/schema_upgrade/02_performance_views_hostname_to_uishortname.sql" is needed for existing installations. Let me know if encountering any problems. Cheers

from pgobserver.

The only problem i'm running into is the constraint on the hosts-table. We used ui_shortnames with underscores in it, what was fine previously. So I changed the constraint to include the _ character and it's running fine now. Thanks for this!

from pgobserver.