work on/with z-schema about z-schema HOT 11 CLOSED

Yes we can talk :)

First of all, what's purpose of this factory stuff? Do I understand correctly that it is supposed to generate random objects passing schema? I'm not really familiar with the term when it's not related to http://en.wikipedia.org/wiki/Factory_method_pattern

I don't mind exposing internal components where useful, I know the project needs quite a bit of refactoring that I didn't have time to do lately.

Anyway as long as it doesn't break any of the working tests, I'm happy to help you where I can.

from z-schema.

https://github.com/thoughtbot/factory_girl

this is the ruby standard way of making test objects for unit tests; one purpose we are using it for in Leap Motion is making a set of "invalid" objects that we return from methods when we are unable to return a valid object for a function -- a kind of verbose "nuull".

from z-schema.

Well proceed as you see fit and ping me if you'll need any help.
I'll merge your changes when it's done. We don't need to start another branch as from what I understand, your changes will not break any existing behaviour and won't introduce any performance overhead to the current implementation.

from z-schema.

https://github.com/leapmotion/z-schema/tree/factory

added a few things —

• using grunt-umd to make ZSchema browser compatible (with external bluebird
• only starting to test under browser; wouldn’t mind a bit of help as to how to move the tests into browser/mocha as your test structure is a bit more sophisticated than I’m used to.

I am using Factory on my own company’s code, FWIW, to span “null” versions of our core objects.

I will work with this a bit more before I do a full pull request.

On Feb 24, 2014, at 1:58 PM, Martin Zagora [email protected] wrote:

Well proceed as you see fit and ping me if you'll need any help.
I'll merge your changes when it's done. We don't need to start another branch as from what I understand, your changes will not break any existing behaviour and won't introduce any performance overhead to the current implementation.

—
Reply to this email directly or view it on GitHub.

NOTE: The information in this message and any attachments is confidential
information intended only for the individual to whom it is addressed. If
you are not the intended recipient, any distribution of this message or its
attachments is prohibited. If you have received this email in error,
please immediately notify us and delete the message. Thank you.

from z-schema.

Yes, I'm currently busy but later I could pull your changes to my own branch and work on browser tests so you can focus on your Factory implementation.

from z-schema.

Update: I pulled your current changes into my new branch https://github.com/zaggino/z-schema/tree/browser and will work on the browser tests. Then will merge into master.

from z-schema.

Thanks!

Dave

On Feb 26, 2014, at 2:38 PM, Martin Zagora [email protected] wrote:

Update: I pulled your current changes into my new branch https://github.com/zaggino/z-schema/tree/browser and will work on the browser tests. Then will merge into master.

—
Reply to this email directly or view it on GitHub.

NOTE: The information in this message and any attachments is confidential
information intended only for the individual to whom it is addressed. If
you are not the intended recipient, any distribution of this message or its
attachments is prohibited. If you have received this email in error,
please immediately notify us and delete the message. Thank you.

from z-schema.

Most of the tests now pass in Chrome acc57eb

Quite a work to follow, but at least I got it running without modifying the test files.

from z-schema.

Studying it, I'm not really a fan of splitting the source into that many files, I don't see the benefit and it complicates things, because those files are not really modules or classes maybe except for Report. I'd prefer to keep ZSchema as a single file for now. Any required parts of it can be exposed publicly. I'll think of this while I continue with the browser stuff.

from z-schema.

As you will -- I think you will find very few fans of the one big file theory of programming.

from z-schema.

@bingomanatee I've closed this yesterday because z-schema is now actually split into more files, see https://github.com/zaggino/z-schema/tree/master/src

from z-schema.