Giter Club home page Giter Club logo

Comments (5)

jensolafkoch avatar jensolafkoch commented on June 3, 2024 1

Thanks a lot! Firefox does work again (6.0.3) ... :-)

from just-read.

ZachSaucier avatar ZachSaucier commented on June 3, 2024

Hey Jens, thanks for posting!

I recently updated Just Read to use Readability.js from Mozilla, which is what Firefox uses in its reader view, for Just Read's auto-selection because it outperformed the very simple auto-selection algorithm that I came up with for Just Read.

From what I can tell, it looks like at least some of this website is rendered using Vue.js and it uses an HTML attribute of @click, which is not a valid HTML attribute and breaks Readability.js.

I went ahead and raised an issue with Readability.js. If they are responsive I am betting it will get fixed pretty quickly because I think it's a pretty simple fix.

I can also catch this error and fall back to the old method of auto-selection in Just Read. I didn't do that originally because I assumed that Readability.js would never error like this (it never did in my tests). I'll get that updated tonight (probably ~12 hours from now).

The changes to the original page are expected -- Readability.js and Just Read remove things from the original page for performance reasons. If Just Read fails to load then the original page ends up in a broken state.

from just-read.

jensolafkoch avatar jensolafkoch commented on June 3, 2024

Hi Zach,

great + thanks for letting me know! Will check during the next couple of days after your update!

Best, Jens

from just-read.

ZachSaucier avatar ZachSaucier commented on June 3, 2024

I just pushed version 6.0.1 to the webstores which should handle this situation and work on sites like these. It will take some time to reach your devices. Let me know when you get it to confirm it works for you!

from just-read.

ZachSaucier avatar ZachSaucier commented on June 3, 2024

It looks like the submission in Chrome failed so I re-submitted now. It should work in Firefox now but in Chrome it will take a few more hours.

from just-read.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.