Giter Club home page Giter Club logo

Comments (5)

yzhouas avatar yzhouas commented on July 24, 2024 2

Codes updated.

from pd-denoising-pytorch.

yzhouas avatar yzhouas commented on July 24, 2024

I am not sure but it should be fine with images of 512x512. The testing-on-full-image version is to crop larger images to smaller patches for denoising and then combine them back. It will solve the out-of-memory issue but increase the execution time. If needed, I will release it in a few days.

from pd-denoising-pytorch.

JeffMusgrave avatar JeffMusgrave commented on July 24, 2024

Wow thanks for taking the time out of your weekend to do that! I'll try to test it tonight or tomorrow evening.

from pd-denoising-pytorch.

JeffMusgrave avatar JeffMusgrave commented on July 24, 2024

Just tested with your larger example images. Seems to work! Thanks!

from pd-denoising-pytorch.

Tetsujinfr avatar Tetsujinfr commented on July 24, 2024

Thanks for the repo, works on first time. Initially I tried the full frame inference code, and that was burning over 8GB of memory to process a 672x344 frame!! (including 3gb of swap memory on my limited but capable embedded system)
But then I saw this issue thread and I continued to read until the end of the repo readme and tried the Demo_on_full_image.py instead of test.py : that worked brilliantly. Actually it ran much faster and is much more stable on my system given that it did not use any swap memory.

I think you should highlight the memory friendly option earlier in your readme, like a mention "For limited memory users, I recommend using the Demo_on_full_image.py, see down below."

I did not notice any clear artefact in the memory friendly inference, real nice job.
I attach an example of an original image, the full frame processed one, and the cropped processed one (wbin=256, did consume around 3GB of memory max) for anyone interested.

original

denoised_full_frame

denoised_tiles

from pd-denoising-pytorch.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.