Comments (4)
That makes sense, will remove the dependencies in next version.
from python-text-distance.
Thanks for the suggestion. The reason for having a logging config file is to make it easy to control logging for all modules in one place so I think we should keep the logger config file.
However logging also supports json
as its config file so one workaround will be to rewrite the logging config file into a json which can be read using Python built-in library.
from python-text-distance.
I still think it should be the apps authors responsibility. Config file is not the best option for everybody. e. g.:
- a CLI tool might want to vary its config settings based on how many
-v
switches it got - a GUI application might log into its UI and allow users to change logging settings on the fly
- a Twelve-Factor proponent could prefer to store the whole config in the environment – not that it makes too much sense if there are two or three deploy variations, but some people do that :)
I'd say this code
with open(logger_config_yaml_path, "rt") as f:
config = yaml.safe_load(f.read())
logging.config.dictConfig(config)
belongs in the application itself as it's way too specific.
from python-text-distance.
Changes made per suggested, thanks again for suggestion.
from python-text-distance.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-text-distance.