Giter Club home page Giter Club logo

Comments (7)

yurisuika avatar yurisuika commented on August 20, 2024 1

It would appear that Health Overlay now allows you to modify the position of its GUI elements within its config.

While I could break into these and modify them, perhaps it is just best to leave them alone and remove support for HO.

Upside on still trying is that it would be easier on the user who wants to simply move stuff around as it was.

If not, then the user has complete separate control over it, but must manually modify HO's position. It seems that you must restart the game for HO's config to reload. I am not seeing any command to reload the config, so that would be up to HO to implement. This would be rather annoying for the user IMO.

The other option is to add individual toggles for each mod in Raised's config. I have thought about this over the past few months; this presents a good case to do so. It would allow for Raised overriding HO's positioning if the user so desires for it to do so.

from raised.

yurisuika avatar yurisuika commented on August 20, 2024 1

I personally wouldn't be too concerned with it though; you definitely don't need to go out of your way to make a workaround for it, but the thought is definitely appreciated. For now I'll close this. I suppose this specific issue would come up again if you end up backporting the changes, but for now the deed is done.

from raised.

yurisuika avatar yurisuika commented on August 20, 2024

Thanks! I'll look into fixing this soon!

from raised.

Terrails avatar Terrails commented on August 20, 2024

Ah, just got a similar bug report on my repo. If you want to modify any config value, you can use the set method from each ConfigOption instance. This value will then also be written to the config file. You can see this here. The only issue I have noticed with this is that forge sometimes errors while saving to config file for some odd reason. I am still looking into that and that's why I also disabled the config screen I made on forge. Using set on fabric works perfectly.

from raised.

Terrails avatar Terrails commented on August 20, 2024

Forgot to say this, but I would be willing to implement a way to just set the config value temporarily without saving to the config file. The only issue I can see being created with this is that touching the config screen and applying any changes would overwrite the values with the ones from the config file.

from raised.

yurisuika avatar yurisuika commented on August 20, 2024

Thanks for the response! I guess the question is really as to why for the extravagant coordinate alignment system?

I can just continue to mixin in much the same manner as before and have the same results if the player does not change the coordinates in the config themselves. Then it is not so much of an issue asides from HO's config's Y position being off by the amount that Raised is altering it.

I'd much rather that be the case than straight up killing off user configurability by forcing setting HO's config. It sort of stays in character for Raised to be altering anything set by other mods by X pixels anyways. In reality this is probably a moot point, but I just don't want to be overriding this in lieu of some use cases that I am not aware of.

from raised.

Terrails avatar Terrails commented on August 20, 2024

Thanks. I'll look into adding compatibility back on my side and will definitely add a warning when modifying the heart bar position in case Raised is present. No need to worry about backports as I am focusing on 1.19 currently.

EDIT: Ah you just added the compat back. I'll just add a warning then.

from raised.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.