step01_get_geotiff doesn't skip download when file exist about licsbas HOT 7 CLOSED

Thank you very much for reporting the issue and suggesting the modification. I will update the code.

Regarding the elif statement, I think I should update all
[el]if not tools_lib.download_data(*, *): print...
lines to
else: tools_lib.download_data(*, *)
as you suggested.
Do you think is that right?

from licsbas.

You're welcome. Yes, that is right. I also think it's better not to return any value in download_data because the error already caught and the data is saved not returned.

I found out that it's better to send HEAD than GET when checking mli.tif to find the earliest date in which mli is available. So, it won't download the entire file but only check if link exist.

from licsbas.

Thanks! I see your points. I will update the codes soon.

from licsbas.

You are welcome, glad to hear that ^^

from licsbas.

I will update the codes almost as you suggested, but I will not include "raise SystemExit(error)" in download_data because the not-downloaded data are not necessary for later steps (i.e., can be skipped) and the step01 processing should not be stopped.

Please let me know if you have any thoughts about this.

from licsbas.

Oohh, so that's okay to ignore not-downloaded data ? Then it is not necessary to raise any exception and systemexit.

from licsbas.

Yes, sometimes missing data exist in LiCSAR products but later steps in LiCSBAS can run without them.

I have updated the codes. Thank you for your suggestion.

from licsbas.