Giter Club home page Giter Club logo

Comments (6)

ysard avatar ysard commented on July 23, 2024 1

Hi, thank you for the review!

  • Indeed the contrast in this example is catastrophic, it is curious whereas this is managed by bootstrap; I will see to fix the color.

  • The hackerstyle is more a demonstration that the style can be changed quite easily than anything else; I will see to fix the contrasts there too.

  • What do you think about displaying names in bold and italicized content?

The tables were the choice of Cookie Manager+ however it is not planned to develop a new interface of this type for the moment (too time-consuming) :)

from cookie-quick-manager.

exploide avatar exploide commented on July 23, 2024

Great, thanks for your reply.

I also thought about displaying name in bold. But italicized value could easily look odd. Cannot fully imagine the latter but perhaps leave it normal. However, while displaying the name in bold would be an improvement, I'm still not sure if this looks nice. What about the first equal sign then? Maybe twoline? First line shows name in bold, second line shows value? Could look cleaner but on the other hand increases the necessary space for showing one cookie... Don't know.

Yeah, the table view was only an idea as it allows to quickly gain an overview. But it's not important and of course up to you. Probably the UI will slowly enhance over time?!

from cookie-quick-manager.

ysard avatar ysard commented on July 23, 2024

Well here are the two possibilities for the middle column:

two lines

or

one line

I do not know what to choose: p

from cookie-quick-manager.

exploide avatar exploide commented on July 23, 2024

I'm also not the right person when it comes to style decisions :D

Think both are fine. Guess I like the two line approach a bit more, but the other one is also better than the previous styling.

Thanks for addressing my suggestions.

from cookie-quick-manager.

ysard avatar ysard commented on July 23, 2024

Finally I opted for the solution on only 1 line, because some domains contain a lot of cookies and the gain of space is important :)

from cookie-quick-manager.

Boruch-Baum avatar Boruch-Baum commented on July 23, 2024

I've hacked the css to provide a dark theme that seems to work. Unfortunately, the modifications span several files: menu.html, options.html, and hacker_style.css.

My suggestion would be remove the hard-coded css from the all the html files, and to move them to a single css file "default.css", which would be a template for hacker_style.css, meaning that all the entries currently in hacker_style.css would exist in default.css but with their default values. Then, add to the options.html a "user-defined.css" that would point to a file outside the xpi blob, say ~/.mozilla/extensions/cookie-quick-manager/user-defined.css. Also, because it's common for people to be using a dark theme, you may want to also add a dark-theme.css within the xpi blob, along with an entry in the options.html

That way, a user could define a custom skin without having to mess with the xpi blob, and without having to keep updating it every time the extension is updated. For now, if I want to keep my dark theme, which I really prefer, it will be a pain every time I update the extension.

I'm happy to share the changes I've made as a diff ; I haven't proposed this as a PR because: a) I'm lazy; b) I would want to know first whether you're even interested; c) it's real simple, and you may want to do it your way anyway.

Edit: Ooops, should maybe have told you at the beginning that I think this extension is great, and thanks for writing it.

from cookie-quick-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.