Comments (3)
That sounds funny.
The implementation should stop handling them when the length is right and return.
I can think of a few reasons:
- are both messages submitted at once? If so, the parser will read the first header, catch the length, keep that and drop the rest. If it needs to be able to handle many messages that way, it should be easy enough to do, although we'll need to define an API for that.
- do the messages start by
horj? As far as I know, the heartbeat one should be handled fine, but the json one will then go through the jsx parser, which might just never complain about it and keep looping in the continuation-based API.
It sounds likely it's number 1. Is this some part of the standard socket.io protocol that you should be able to just append messages to each other?
from socket.io-erlang.
After a discussion, we've decided it is likely option no.1 that happens, especially with long polling calls that might buffer them up.
While we would probably need a test case to document everything, I'll just change the parser to return a list of messages if more than one exists.
Seeing the following: https://github.com/yrashk/socket.io-erlang/blob/master/src/socketio_transport_htmlfile.erl#L105
because we use gen_event to handle everything, I should be able to change the bits of code similar to the one above for something that just sends many notices. No messages should be lost after that.
from socket.io-erlang.
This is fixed in 16815ab
Note that it is assumed that the first message of the string is the first one received.
from socket.io-erlang.
Related Issues (20)
- Requests getting lost when handle_request receives non-selectively HOT 14
- close client connection HOT 2
- socketio_listener:start/1 HOT 14
- disconnect event not sent for more than one client HOT 6
- Tests should be possible to run on something else than OSX
- Unable to stream to Android Froyo HOT 1
- submodules will have to be changed soon HOT 1
- git update submodule fails HOT 3
- unicode crash HOT 15
- socketio_data:encode does not count escapes when determining the length of a JSON string HOT 20
- Cannot include ex_uri.hrl HOT 7
- No disconnect by timeout for xhr-polling HOT 1
- Variable 'Host' is unbound when compiling HOT 3
- TCP Error when a client refresh HOT 4
- GET http://localhost:7878/socket.io/socket.io.js 404 (Not Found) HOT 4
- Can't use two event handlers for two different ports from the same socketio application HOT 3
- wrong post
- Can't run demo HOT 4
- Error on demo run HOT 18
- Not able to connect socket server using angular 6 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socket.io-erlang.