Memoized methods cause attributes to leak into other records about panko_serializer HOT 6 CLOSED

A Serializer isn't initialised with a single instance of an object, render takes the object to serialize. Therefore using instance variables in a serializer isn't going to be per object.

I agree this is unexpected from using the ArraySerializer, but if you are using normally you do FooSerializer.new.render(object) and in that case I wouldn't expect instance variables to work.

from panko_serializer.

@mikebaldry thanks for the explanation.

@emptyflask you need to think about serializers as pure functions with no state and you need to build your application with this in mind.

If you have any more questions/ideas how can I simplify/solve panko to help you better please lmk.

from panko_serializer.

I was coming at this from Active Model Serializers so made some assumptions about how this was expected to work...

To be clear I wouldn't expect an instance var to persist across more than one object -- I'm thinking more of a situation where there's a time-consuming method that looks up a related object (like a remote image) that is then referenced multiple times in the same serializer (writing attributes like url, width, height, etc). The instance var is only intended to memoize the lookup method for that single record's relation.

It sounds like I might need a presenter layer between the model and the serializer if I want to do this.

from panko_serializer.

@emptyflask I tried thinking about this and I think creating new objects when serializing or adding some caching mechanism support here will complex Panko.

The only solution I can suggest here is using something like Rails.cache or passing cache object via the context.

from panko_serializer.

from panko_serializer.

@emptyflask I am closing this issue, if you have any idea on how to improve here, please open new issue (and reference this for context if needed).

from panko_serializer.