Comments (6)
A Serializer
isn't initialised with a single instance of an object, render
takes the object to serialize. Therefore using instance variables in a serializer isn't going to be per object.
I agree this is unexpected from using the ArraySerializer
, but if you are using normally you do FooSerializer.new.render(object)
and in that case I wouldn't expect instance variables to work.
from panko_serializer.
@mikebaldry thanks for the explanation.
@emptyflask you need to think about serializers as pure functions with no state and you need to build your application with this in mind.
If you have any more questions/ideas how can I simplify/solve panko to help you better please lmk.
from panko_serializer.
I was coming at this from Active Model Serializers so made some assumptions about how this was expected to work...
To be clear I wouldn't expect an instance var to persist across more than one object -- I'm thinking more of a situation where there's a time-consuming method that looks up a related object (like a remote image) that is then referenced multiple times in the same serializer (writing attributes like url, width, height, etc). The instance var is only intended to memoize the lookup method for that single record's relation.
It sounds like I might need a presenter layer between the model and the serializer if I want to do this.
from panko_serializer.
@emptyflask I tried thinking about this and I think creating new objects when serializing or adding some caching mechanism support here will complex Panko.
The only solution I can suggest here is using something like Rails.cache
or passing cache object via the context
.
from panko_serializer.
from panko_serializer.
@emptyflask I am closing this issue, if you have any idea on how to improve here, please open new issue (and reference this for context if needed).
from panko_serializer.
Related Issues (20)
- Delegate + aliases not working as expected HOT 1
- Adding a custom root name for array serializer HOT 1
- Relax `oj` dependency HOT 3
- Is anyone actively maintaining this project? HOT 2
- Using ActiveRecord's pluck when possible
- Serialize attributes which is used `serialize` in active model definition
- Benchmarks task not working HOT 1
- How do I selectively display a key/value pair? HOT 2
- Alias declaration is ignored when method is added HOT 2
- Migration from AMS HOT 3
- Filter on array serializer? HOT 4
- Conditionally include associations in JSON response HOT 3
- Rendering recursive relations HOT 2
- Add context to relations has_one/has_many
- Ability to skip nil values HOT 2
- Loading dynamic field names during serialization HOT 1
- Documentation questions HOT 3
- Status HOT 1
- Serialization of single object with context / options HOT 2
- How to use a raw JSON string inside a serializer? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from panko_serializer.