Comments (4)
@BorisBresciani I can add support for has_many :pankos, embed: :ids
in serializer like AMS.
wdyt?
from panko_serializer.
It is a good idea or if not to do as simple attributes without specifying "has_many" like my example
from panko_serializer.
It's simple to do embed
because at serializer definition time I don't know which model is serialized in advance so I can't tell if panko_ids
is field or method and detecting this at runtime can be a huge performance loss.
I have two options to tackle this:
- Move to strict serializes and don't allow polymorphic serializers, so in addition to attributes, you will specify
model Post
- and I can tell automatically which method it is, gather type information etc. - At runtime detect which model I am serializing and cache results of attributes mapping per serializer.
Both solutions will take some time to develop if you can wait two weeks (at max), I will implement them now and in the meanwhile you will do:
attributes :panko_ids
def panko_ids
object.panko_ids
end
or
attributes :panko_ids
delegate :panko_ids to: :object
from panko_serializer.
Hi,
The second solution seems better
from panko_serializer.
Related Issues (20)
- Delegate + aliases not working as expected HOT 1
- Adding a custom root name for array serializer HOT 1
- Relax `oj` dependency HOT 3
- Is anyone actively maintaining this project? HOT 2
- Using ActiveRecord's pluck when possible
- Serialize attributes which is used `serialize` in active model definition
- Benchmarks task not working HOT 1
- How do I selectively display a key/value pair? HOT 2
- Alias declaration is ignored when method is added HOT 2
- Migration from AMS HOT 3
- Filter on array serializer? HOT 4
- Conditionally include associations in JSON response HOT 3
- Rendering recursive relations HOT 2
- Add context to relations has_one/has_many
- Given two serializers with `filters_for`, context isn't passed to the associated serializer HOT 1
- Attrribute methods not running HOT 4
- how to customize association sorting? HOT 2
- Can't compile on windows. Fix seems easy. HOT 5
- Serialization of single object with context / options HOT 2
- How to use a raw JSON string inside a serializer? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from panko_serializer.