{{expr}} in custom templates has trailing period about vscode-postfix-go HOT 5 CLOSED

Thank you for pointing it out.
We will look at it soon.

from vscode-postfix-go.

Can you please recreate this bug and add more details in you issue? Because it working fine without any trailing period.

from vscode-postfix-go.

Thank you for this extension btw. Its really great!
Here is the json for the custom template

{
    "name": "handleerr",
    "when": [
      "function-call"
    ],
    "description": "Creates an Internal Error",
    "body": "${1:val}, err := {{expr}}\nif err != nil {\n\tsvc.logger.Print(err)\n\treturn ${2:response}, toolbox.InternalError(err)\n}"
  }

This is what the go code looks like before the postfix call

func (svc *service) CreateAccessToken(
	ctx context.Context,
	access AccessToken,
) (AccessToken, error) {

	svc.fixedLengthSession(ctx, access.user, validTo)

}

This is how I'm calling the postfix snippet

func (svc *service) CreateAccessToken(
	ctx context.Context,
	access AccessToken,
) (AccessToken, error) {

	svc.fixedLengthSession(ctx, access.user, validTo).handleerr

}

And this is what it changes to

func (svc *service) CreateAccessToken(
	ctx context.Context,
	access AccessToken,
) (AccessToken, error) {

val, err := svc.fixedLengthSession(ctx, access.user, validTo).
if err != nil {
	svc.logger.Print(err)
	return response, toolbox.InternalError(err)
}

}

The period at the end of this line should not be there

val, err := svc.fixedLengthSession(ctx, access.user, validTo).

I suspect its line 36 in the postfixCompletionProvider

.map(t => t.buildCompletionItem(code, position, line.text.substring(dotIdx, position.character)))

The suffix is the substring starting at the dotidx going to the position character. Not sure if maybe it needs to start at dotidx+1. That seems to fix my issue but I'm not sure if that would cause problems elsewhere.

from vscode-postfix-go.

Sorry for being late, I didn't notice the issue.
I will look into it.

from vscode-postfix-go.

This should be fixed in 0.0.12 which was just released.
Thank you for reporting.

from vscode-postfix-go.