Giter Club home page Giter Club logo

Comments (7)

BalthazarB avatar BalthazarB commented on May 13, 2024

I would like to fix this bug

from pretty-ts-errors.

yoavbls avatar yoavbls commented on May 13, 2024

@BalthazarB you're welcome to do it 🙂

from pretty-ts-errors.

MikeJakuszewski avatar MikeJakuszewski commented on May 13, 2024

Is this still open?

from pretty-ts-errors.

yoavbls avatar yoavbls commented on May 13, 2024

@MikeJakuszewski yes

from pretty-ts-errors.

MikeJakuszewski avatar MikeJakuszewski commented on May 13, 2024

@yoavbls, what is the expected behavior we want? Do we want to remove the inner quotes? I think I found the error, it is under format/addMissingParentheses.ts

from pretty-ts-errors.

yoavbls avatar yoavbls commented on May 13, 2024

@MikeJakuszewski The expected behavior is without removing the inner quotes:
type null is not assignable to type "' 'Oh no"

You're welcome to try to fix it, and I can help in Discord if needed
Unfortunately, I don't think it's the addMissingParentheses function because it should called only when a type ends with ...

from pretty-ts-errors.

yoavbls avatar yoavbls commented on May 13, 2024

I'm pretty sure I fixed all the cases of string literal types that did not escape properly here.

Give it a try with 0.5.2 and reopen this issue if you find new cases like this

from pretty-ts-errors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.