Comments (2)
Good point, that's actually something I kept in my head for later when working on miditoolkit.
I think keeping all the controls in Track.controls
is better, and it's simpler to write only the controls. Track.pedals
should just be for users to use.
Now avoid any pedal-control inconsistency, we could ensure that each pedal stored has its Control
equivalent. This shouldn't be a problem when parsing as the pedals are deduced from the controls. But then, if a user is adding a pedal to any Track.pedals
, we could add the equivalent control in Track.controls
. And also each time a control is added to Tracks.controls
, if its a pedal we could just add the pedal to Track.pedals
.
Setting Track.pedals
as a property with setters / deleters would achieve this purpose.
It would make sure that the user can use/add any pedals without duplication, even for let's say two identical pedals (that may append even if it's not natural).
from symusic.
It would be challenging to achieve this encapsulation if common operations in list
is allowed for pedal
like slice.
Also, in this case, we may need to store two references of the corresponding control change in pedal, and a reference of pedal in control change event.
from symusic.
Related Issues (20)
- [Question] Performance improvement compared to mido HOT 4
- Incorrect/inconsistent treatment of program change in dump_midi HOT 9
- Bug when multithreading with macOS since 0.3.4 HOT 14
- Unable to build on linux HOT 10
- Adding a function to easily modify the event times at a score level (like `midi.adjust_times` in PrettyMIDI) HOT 35
- Question and Request: Sorting after conversion to second HOT 5
- Inconsistency between the interface of vector bindings and python list & potential wild pointer problems. HOT 55
- merging tracks HOT 3
- Segmentation Fault when reading Score from MIDI files HOT 3
- Make `Score.clip` include the ongoing tempo/time signature/key signature at `start` HOT 7
- Inconsistency with Score when writing to Audio HOT 11
- MIDI with negative beginning tick HOT 5
- MIDI files with simultaneous note on/off ticks result in incorrect note durations HOT 3
- nanobind v2.0.0 breaks building compatibility HOT 3
- nanobind problem HOT 7
- Suppression of Nanobind leak messages HOT 6
- Set-Tempo events not applied correctly to timestamps in multi-track files HOT 1
- MIDI message level interface design HOT 3
- Note durations in a midi file increase after loading and dumping via symusic.Score HOT 3
- Nanobind Issue HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from symusic.