Giter Club home page Giter Club logo

Comments (10)

samdark avatar samdark commented on June 30, 2024

Thanks for reporting. Feel free to do a pull request.

from yii2-jui.

buttflattery avatar buttflattery commented on June 30, 2024

@samdark sure, but i havent contributed before in any of Yii's repo, are there any guidelines to follow ?

from yii2-jui.

samdark avatar samdark commented on June 30, 2024

Yes: https://github.com/yiisoft/yii2/blob/master/docs/internals/git-workflow.md

from yii2-jui.

buttflattery avatar buttflattery commented on June 30, 2024

@samdark what i understand is that i have to fork and clone the main Yii2 repo first to contribute the fix to this extension. am i right ? or should i do those 3 steps for the extensions repo directly rather than the Main Yii2 repo first? which i dont think so is the right way.

Sorry to bug you about this.

from yii2-jui.

samdark avatar samdark commented on June 30, 2024

Yes, you are right. Yii2 repo first.

from yii2-jui.

samdark avatar samdark commented on June 30, 2024

Any luck with the pull request?

from yii2-jui.

buttflattery avatar buttflattery commented on June 30, 2024

@samdark forgot totally as i was busy lately, just going to push the code can you tell if the CHANGELOG entry will go under 2.0.8 under development section ? i am sure it goes under that.

from yii2-jui.

samdark avatar samdark commented on June 30, 2024

Merging is blocked as expected since we need to check the pull request first.

from yii2-jui.

buttflattery avatar buttflattery commented on June 30, 2024

@samdark alright, and dont you think a test for the altField with inline display mode should be added too.

from yii2-jui.

samdark avatar samdark commented on June 30, 2024

Yes, sure it should.

from yii2-jui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.