ast tree does not record selected rule about cpp-peglib HOT 8 CLOSED

@timmerov, thanks for the feedback. Could you give me more detailed information, so that I can try to reproduce and debug it?

from cpp-peglib.

premature send sorry. edited.

from cpp-peglib.

more details.
input:

syntax = "proto3";
import "path/to/some/file";
package timmerov;
message Foo {
    int x = 1;
}
enum Fred {
    d = 0;
}

output ast:

  - statement[string] ("proto3")
  - statement[string] ("path/to/some/file")
  - statement[token] (timmerov)
  + statement[message_statement]
    - token (Foo)
    + field[type_decl]
      - type[token] (int)
      - token (x)
      - number (1)
  + statement[enum_statement]
    - token (Fred)
    + enum_decl
      - token (d)
      - number (0)

obviously i'm going to want to do different things for the "syntax" and "import", statements.
but ... how do i tell which one is which in the ast?

from cpp-peglib.

a workaround is to use make more rules.
as per here: https://github.com/timmerov/technomancy/blob/master/peg/src/main.cc
but that makes the grammar somewhat less than ideal. ;->

p.s. thanks, @yhirose ! this thing kinda rocks. ;->
and is waaaaay more gooder than our current bison/flex solution.

from cpp-peglib.

@timmerov, I changed the peglib.h to keep the selected rule id in an ast node at b76e4fe

Here is the output from peglint:

+ statements
  - statement/0[string] ("proto3")
  - statement/1[string] ("path/to/some/file")
  - statement/2[token] (timmerov)
  + statement/4[message_statement]
    - token (Foo)
    + field/0[type_decl]
      - type[token] (int)
      - token (x)
      - number (1)
  + statement/3[enum_statement]
    - token (Fred)
    + enum_decl
      - token (d)
      - number (0)

Ast node has a new member choice which shows which rule has been applied.

Does it work for you?

from cpp-peglib.

that looks really good. thanks!
will want to try it.
maybe next week.
feedback then. ;->

from cpp-peglib.

next week came early this week. ;->
i switched to my preferred grammar.
https://github.com/timmerov/technomancy/blob/master/peg/src/main.cc
it took me a bit to figure out to use original_choice instead of choice.
but after that things look swell.
added benefit is i can switch on choice (an int) instead of if-else comparing strings.
thanks!

(close at will)

from cpp-peglib.

Yes, original_choice should be used when ast is optimized. Sorry that I didn't mention it.
Thanks for the valuable feedback!

from cpp-peglib.