Giter Club home page Giter Club logo

Comments (11)

addyosmani avatar addyosmani commented on May 26, 2024

If any bootstrap.css file is being placed into the users initial project when they have declined Twitter Bootstrap being included, that is a bug afaik.

Reviewing the output:

Writing compiled Bootstrap
Reading /Users/addyo/projects/yeoman/cli/node_modules/yeoman-generators/lib/generators/yeoman/app/templates/bootstrap.css...OK
Writing app/styles/bootstrap.css...OK

I can confirm this is currently the case. @paulirish I assume we should only be writing Bootstrap when the user has opted into it. If this is correct, I'll change this to fix tomorrow unless someone gets to it before me.

from generator.

sindresorhus avatar sindresorhus commented on May 26, 2024

@addyosmani It's by design, you or @paulirish wanted to always include Bootstrap. The prompt is just asking if you want Compass Bootstrap, otherwise compiled bootstrap is included.

from generator.

addyosmani avatar addyosmani commented on May 26, 2024

Cool cool. If we always want to include Bootstrap I think we should make the language a little more clear. @paulirish could you confirm if we always wanted to include Bootstrap as a part of init?

from generator.

jimray avatar jimray commented on May 26, 2024

This definitely left me confused. I ran init expecting that I could skip Bootstrap, answered 'no' to all of the setup questions, and found a new project full of Bootstrap when all I wanted was HTML5 Boilerplate, jQuery and Modernizr. This is what's implied documentation as well. I'm sure Bootstrap is great and fitting for certain projects but not surely not every project.

from generator.

aeonbeat avatar aeonbeat commented on May 26, 2024

What's the status of this, being a month later now?

from generator.

paulirish avatar paulirish commented on May 26, 2024

I'm sorry, I was expecting the prompt question to give you compass
bootstrap, otherwise no bootstrap at all.

from generator.

addyosmani avatar addyosmani commented on May 26, 2024

@paulirish Thanks for the clarification. We currently have it setup to use Compass or default to Bootstrap CSS if that isn't opted for. We can change the behaviour to match the original intention in the next release.

from generator.

sindresorhus avatar sindresorhus commented on May 26, 2024

Sure.

What do you think about a nested prompt?

  • Would you like to include Twitter Boostrap?
    • Would you like the Compass version instead of compiled CSS?

The nested one is only shown if the first one is true.

from generator.

trumbitta avatar trumbitta commented on May 26, 2024

+1 for nested prompt

Also, I'd leave room for the hypotetical coming of a LESS version

from generator.

sindresorhus avatar sindresorhus commented on May 26, 2024

On second thought. Now that Bootstrap is on Bower, we can just ask for the Compass in the prompt and if they choose No, they're still free to do yeoman install bootstrap. In the revised generator system we might even download the Compass version from Bower, to make that to easily update-able.

from generator.

sindresorhus avatar sindresorhus commented on May 26, 2024

Fixed in yeoman/generator-webapp@3010298

from generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.