Comments (11)
If any bootstrap.css file is being placed into the users initial project when they have declined Twitter Bootstrap being included, that is a bug afaik.
Reviewing the output:
Writing compiled Bootstrap
Reading /Users/addyo/projects/yeoman/cli/node_modules/yeoman-generators/lib/generators/yeoman/app/templates/bootstrap.css...OK
Writing app/styles/bootstrap.css...OK
I can confirm this is currently the case. @paulirish I assume we should only be writing Bootstrap when the user has opted into it. If this is correct, I'll change this to fix tomorrow unless someone gets to it before me.
from generator.
@addyosmani It's by design, you or @paulirish wanted to always include Bootstrap. The prompt is just asking if you want Compass Bootstrap, otherwise compiled bootstrap is included.
from generator.
Cool cool. If we always want to include Bootstrap I think we should make the language a little more clear. @paulirish could you confirm if we always wanted to include Bootstrap as a part of init
?
from generator.
This definitely left me confused. I ran init expecting that I could skip Bootstrap, answered 'no' to all of the setup questions, and found a new project full of Bootstrap when all I wanted was HTML5 Boilerplate, jQuery and Modernizr. This is what's implied documentation as well. I'm sure Bootstrap is great and fitting for certain projects but not surely not every project.
from generator.
What's the status of this, being a month later now?
from generator.
I'm sorry, I was expecting the prompt question to give you compass
bootstrap, otherwise no bootstrap at all.
from generator.
@paulirish Thanks for the clarification. We currently have it setup to use Compass or default to Bootstrap CSS if that isn't opted for. We can change the behaviour to match the original intention in the next release.
from generator.
Sure.
What do you think about a nested prompt?
- Would you like to include Twitter Boostrap?
- Would you like the Compass version instead of compiled CSS?
The nested one is only shown if the first one is true.
from generator.
+1 for nested prompt
Also, I'd leave room for the hypotetical coming of a LESS version
from generator.
On second thought. Now that Bootstrap is on Bower, we can just ask for the Compass in the prompt and if they choose No, they're still free to do yeoman install bootstrap
. In the revised generator system we might even download the Compass version from Bower, to make that to easily update-able.
from generator.
Fixed in yeoman/generator-webapp@3010298
from generator.
Related Issues (20)
- Minimist CVE HOT 1
- "Which type of client-side component to create?" is missing "Extension" HOT 1
- Introduce a flag to use config in proxymode HOT 1
- Is this project abandoned? HOT 1
- Dependent library tui-jsdoc-template has high severity vulnerabilities HOT 1
- Value from option defined in a composed generator is only available on generator triggered HOT 2
- "Invoke validation failed. User forbidden to perform action" when trigger "More details" button of message extension sample HOT 2
- Cannot Remove Default Add-In HOT 2
- [deps] Check for breaking changes in Dependabot's PRs HOT 1
- Can't install 6.0.1 using npm HOT 5
- Improve readability of fs.test.ts; correct TS problems in it.
- Migrate tests to vitest and add node 20 to ci
- Replace jsdoc with typescript based documentation generator
- Dependency Conflict on `mem-fs` for yeoman-generator 7.x HOT 9
- yeoman-generator should declare an ordinary dependency on 'mem-fs' HOT 3
- Documentation is out of date HOT 2
- yeoman-generator wants conflicting transitive dependencies on mem-fs HOT 3
- How to compose generators in our own ESM-based generator HOT 8
- different document HOT 1
- issue with spawnCommandSync and (linux) mount during generator run HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator.