Helper for re-writing routes about generator HOT 13 CLOSED

We already have Cheerio for modifying HTML. We also have API methods to add scripts and styles.

How does your helper work? Like how do you modify the app.js reliably?

from generator.

It's not particularly sophisticated; it just looks for some line of code, and inserts a block of code before this other line. It also handles indenting the inserted code based on the context that its inserted.

You can take a look at it here: https://github.com/yeoman/generators/blob/master/lib/generators/angular/util.js

The code is not particularly beautiful, so if you think there's a better way for me to do this, let me know.

from generator.

@btford can you expand on what it does? Does it modify HTML or JS? Could Cheerio potentially replace it?

I want it out of the Angular generator in into a more reusable format.

from generator.

It's this. Inserts code after a defined context (example), in this case JS.

from generator.

+1 everything @kevva said.

It's language agnostic; it's just doing dumb string searching. Cheerio could replace the HTML portion, but probably not the JS portion. We'd need to use a JS parser for that.

It's also aware of indentation, etc.

from generator.

Ok, I think a dumb string searching thing could be useful in addition to Cheerio and an Esprima abstraction.

@btford how about making that one a separate module?

from generator.

Separate npm module?

Super hard question: what should I name it?

from generator.

Super hard question: what should I name it?

That's where most refactoring efforts end.

from generator.

@btford create a random module name creator. Though you're still stuck naming that...

from generator.

It's called insertify. You're welcome, Node.js community.

from generator.

:)

from generator.

Niiiiice, @btford. Btw, do we want to use Insertify anywhere? Is there anything Cheerio and Esprima can't give the generator core that we could benefit from?

PS: Needs moar README info :)

from generator.

@addyosmani it's useful for replacing things and don't have to think about what kind of file it is and how to parse it.

We're not going to include it until it gets tests/docs though.

from generator.