Comments (3)
This will require quite a bit of refactoring on our side, since we have countless detectors and a couple terraform modules relying on this being a string. @dichiarafrancesco is part of the team maintaining our internal repos, so any non-backward compatible change to the API must be approved by him or someone else on the Metrics Infra team.
Anyway, I think that your change makes sense; I don't know what's the reason why this was implemented as a string in the first place. Not sure which one of the two approaches you proposed is better, though. And team support for SignalFx is something we always had in our backlog, so that is definitely exciting!
from terraform-provider-signalform.
Will give it a look on Monday. I need sometime to plan the eventual shift from our current way to-do-things and the new one. hope it's not a big blocker for you.
from terraform-provider-signalform.
Would it be an acceptable workaround if, for the time being, we supported both? We could have notifications
as the keyword for the list of strings, and notification
as the keyword for the more thorough HCl description.
from terraform-provider-signalform.
Related Issues (16)
- Clarify terraform version requirement HOT 1
- Community provider list HOT 7
- Suggestion: Docker build HOT 2
- Visualization options for detector HOT 2
- Add ability to configure provider using .netrc file HOT 3
- Support to import resources HOT 2
- Support Tags and Teams for Detectors HOT 2
- Support compound conditions in detectors
- Tag support for Charts
- 400 "Failed to deserialize payload" when creating a dashboard HOT 2
- support a realm scoped URL
- ORG Tokens Creation
- Official provider
- getting runtime error while performing make build HOT 1
- Detector fails to link Slack notification silently HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-provider-signalform.