yellowled / s9y-2k11 Goto Github PK

As of now, trackbacks as well as pingbacks and tweetbacks are displayed as a details element using the trackback body (which is empty for tweet- and pingbacks) as content. This isn't ideal, also the lang constant used for the summary element is kind of misleading since it doesn't show the actual full content of the article sending the trackback.

As of now, the entry preview in the backend is not working correctly. This is most likely due to getting the wrong elements height in preview_iframe.tpl and/or some preview-specific CSS missing.

We could probably trim down the number of selectors used in style.css by using smarter classes. (Note: Don't remove any classes from markup, people might use those in their user.css!)

At some point, we might want to drop respond.js. Here's why:

Modernizr no longer includes (or even offers to include) respond.js in custom builds. That means it has to be loaded seperately.

Long-term, it might be better to drop respond.js altogether and switch 2k11 to a non-mobile-first layout approach. (Oh dear. This could mean a heavy layout rewrite.) Since it's not exactly critical, this is nothing which needs to be fixed any time soon.

For production use, this should get a custom build of Modernizr only containing the features actually used.

Adapt font-sizes for smaller (and bigger) screens.

Maybe reduce the font-size for preformatted text altogether?

To make this easily customizable, the template should have an easy mechanism allowing the user to add own CSS styles, i.e. to change colors etc. These should be in a seperate .css file which should not be part of the 2k11 distribution to keep it from being overwritten by updates. This additional stylesheet should be concatenated with the style.css or added to serendipity.css dynamically. This could be done in the s9y core, by a plugin or in 2k11's config.inc.php, I guess.

Something wrong with the automagic quotes for blockquotes (not q). lang de gets lang en quotes.

It does make sense to hide the reply-to form field (CSS only) if a comment isn't actually a reply or maybe even substitute it with a text representation (in that case, reply-to would only be possible via the link in the original comment).

Embedded media (i.e. YouTube videos via Podcasting plugin) have a dimension issue. I assume it's the simple responsive media CSS (max-width: 100%; height: auto;) vs iframe Styles (since most of the embedded media come in a 3rd-party iframe).

The flex-video technique from http://foundation.zurb.com works fine for the oEmbed plugin, but can not be used here because there is no way to ensure that there's a container element (which is required by flex-video). http://fitvidsjs.com is a possible alternative.

iOS Orientationchange needs a hardcoded path to be loaded by Modernizr.load. This won't work if 2k11 is moved to a different folder.

The microblogging plugin still uses border="0", which is not HTML5 compliant. Even worse, it does not use it as inline CSS but as an HTML attribute. Yikes.

If user has not disabled global nav in theme options, an empty select is created.

As of now, responsive images do not work if the image has a caption, even if image dimensions are removed from the image. This should be a core issue, but maybe look for a temporary fix anyway if possible.

I moved my serendipity directory from one Folder on my Server to another, because of a domain change.
Now the site is crashed and this error message ist displayed:
Keine Schreibrechte für Verzeichnis /var/www/virtual/fridge/blog.fridgeboard.de/templates_c. Bitte korrigieren
(/var/www/virtual/fridge/blog.fridgeboard.de/ is the old folder)

The comment and contact form(s) should use the placeholder attribute. To do this properly (i18n), we probably need new lang constants in the core to assign as placeholder text.

At the moment, textareas can only be resized vertically. This should be loosened, at least in the supposed "desktop resolutions".

The current page marker should get a higher z-index to make it more robust against user.css changes.

Someone reported that the findmore plugin is displayed twice in backend entry preview. Need to check this out some time.

Empty navigation links with no text and link create LIs with emtpy A tags. They should not remain in the markup.

Additionaly, there is no condition for completely remove the navigation bar UL if no links are set at all.

Apparently, the arrows for the polyfill for the details element present an issue on some browsers (Android standard browser only displays the "uncollapsed" arrow correctly) due to the fact that the arrows are added as UTF-8 characters. Maybe look for a different polyfill?

The comment view switch in single entry view, more specifically {$entry.link_viewmode_threaded} and {$entry.link_viewmode_linear}, emits invalid HTML5. Validator message says: "Illegal character in query component."

I assume it's the serendipity[cview]=linear part of the URI, but I'm not 100% sure.

The quicksearch plugin is not HTML5 compliant. While this is no biggie in 2k11 since it emits a proper search form via the template, the plugin should be updated anyway since derivates of 2k11 might not do so.

Georgia seems not the optimum choice for print. Need a new serif font stack for print.

As you can see in my screenshots, using 2K11 and the oEmbed plugin shows Videos with wrong dimensions.

I gave it a try with and

Seems to me that the height of the embeds is not correct. Works fine in other themes.

If a blog uses livesearch, it would need to either attach livesearch to the integrated search form or have an option to not use the integrated search form but emit the quicksearch plugin in the sidebar.

I have updated to branch from 2012-01-30 and live search doesn't work for me. Thought, it has been fixed with #29 ?

The smarty versions of Tweet This and maybe Short URL generated by Microblogging plugin could be integrated in the footer.

The previous/next page links take up a bit of space. Maybe reduce them to just arrows von very small screens (320px).

Issues with @media queries in IE8: @media queries are not applied, resulting in the mobile layout being used in desktop resolutions. Very likely a bug in respond.js, but not sure which one.

style.css needs to some cleanup – look for redundant rules, combine rules for efficiency etc.

Opera offers a configuration option to set presets for popular form fields (i.e. email address) to be filled out automagically. Once filled out, Opera offers these preset for similar form fields. This looks much like HTML5's datalist fields.

The options for these fields are supposed to be black-on-white, but are rendered black-on-black which is inaccessible. However, this is limited to the Windows version of Opera, or at least does not occur in the Linux version. No idea about Opera mac.

I have yet to find a solution for this if there is any which does not resemble a crude hack. I don't consider this to be release-critical, though, given the fact that it's Windows-only. Also doesn't seem to be a rather commonly used feature in Opera?

Not every user might prefer the small screen navigation as a select element. It might be a good idea to offer a toggle menu as an alternative.

The findmore plugin's lazy loading for FB/G+ does not work properly with Modernizr.load. If Modernizr.load is used, the lazy load buttons are not tapable in Andoid standard browser (iOS not yet confirmed). It does work if Modernizr.load or the lazy loading is not used, however.

If an img is floated left and followed closely by a ul or ol, the list bullets "stick" to the floated img. There probably is no other solution than to enlarge the margin-right for the floated img here, but I'll have to check that out closer.

Plus this is buggy in IE9.

To use the current solution for responsive images properly, their img element should not have width and height attributes. However, the s9y media db inserts those by default. So we need a comfortable option to leave those out. (Note that there might be a simpler CSS-only solution (have to check that one first).

I think, there are two wrong timeformates within config.inc.php:

%d-%m-%y should be %d.%m.%Y

%m-%d-%y should be %m/%d/%y

And secondly i miss ISO-format: %Y-%m-%d

For me, it look like this now...

'select_values' => array(DATE_FORMAT_ENTRY => DATE_FORMAT_ENTRY,
'%a, %e. %B %Y' => '%a, %e. %B %Y',
'%d.%m.%Y' => '%d.%m.%Y',
'%Y-%m-%d' => '%Y-%m-%d',
'%m/%d/%y' => '%m/%d/%y',
'%a %d-%m-%y' => '%a %d-%m-%y',
'%a %m-%d-%y' => '%a %m-%d-%y',
'%b %d' => '%b %d',
"%b %d '%y" => "%b %d '%y")

Some things (author in byline and static pages) should be easy to disable via CSS (in user.css). This probably requires some markup changes.

Can we jump to the comment preview when submitting it? JS maybe?

The datetime attribute used in time elements needs a proper timezone offset. Currently, it's format in 2k11 is YYYY-MM-DDTHH:MM:SS+HHMM, the latter part needs to be +HH:MM according to the current HTML5 spec, resulting in invalid HTML.

Note: This might still change in the HTML5 spec.

The entry footer comments link doesn't work with the Disqus plugin. @gbrockhaus is working on a better way to detect Disqus usage in a template. Once that's done, the entries.tpl needs to be adapted to use it.

Check out if it's possible to reference comments to the comment which they reply to using reply/comment id.

.serendipity_entrypaging should have some more white space on left and right side.

See http://dl.dropbox.com/u/343394/2012-01-06_144753.png for example.

The categories plugin should get a proper markup to display nested categories, i.e. nested unordered lists. This saves additional classes or inline styles for indenting nested classes because nested ul and li elements can be addressed via the CSS cascade.

Not styled yet. I keep forgetting these since nobody uses them.

If you also search in comments for something (for example http://blog.bernd-distler.net/index.php?serendipity%5Baction%5D=search&serendipity%5BsearchTerm%5D=excel&serendipity%5BsearchButton%5D=Los%21 -> at the bottom) it seems, there is no style set up or did you really wanted to show results like this? ;)

Polyfilled placeholders don't work properly in IE8, at least not in the comment form (after sending).

See "bug report in the s9y forum":http://board.s9y.org/viewtopic.php?p=10430101#p10430101.

Should think about adding the avatar support via Smarty for comments and trackbacks to enable proper formatting.

frdigeboard reported an issue with the FB like/G+ buttons provided by the findmore plugin.

Positioning is off, the item seem to have extra top/bottom/left padding (which isn't the case). Apparently, this only surfaces when Google web fonts are being used. Might be a load/page rendering issue – it's easier to reproduce in Firefox than in Chrome, which suggests an issue somewhat related to JS performance. It does surface in Chrome as well, but only on the 5th to 10th item of an overview page holding 10 entries, which also suggests page rendering. Also, this seems related to the 1-click-buttons which "hide" the actuall Like/+1 buttons.

Not quite sure about this.