Giter Club home page Giter Club logo

Comments (5)

asigalov61 avatar asigalov61 commented on June 13, 2024

Never mind. I seem to solve all errors/bugs. Sorry to have bothered you.

Check out my work here:
https://github.com/asigalov61/DOREMI

You are welcome to add it/link to it so that your users can use it/try it too.

Let me know if you are interested in example implementations and I will provide you with one as soon as it is ready.

I am using minGPT+your REMI code to see if SOTA results can be achieved.

Thank you again and let me know please.

from remi.

remyhuang avatar remyhuang commented on June 13, 2024

Hi,

Thanks for your re-implementation on the colab. You can find the code segments for converting REMI to MIDI in the utils.py start from #206. If you have any other questions, please let us know.

Looking forward to the results from your re-training on minGPT!

from remi.

asigalov61 avatar asigalov61 commented on June 13, 2024

Thank you so much for your response and your advice.

I did use that code but it produces strange results. I am just trying to figure out if it is my bad coding skills or if there is a problem with your code/implementation.

I am attaching two samples for you to see because one is perfect and the other one is not so much. I am also attaching the random original sample of the input MIDIs.

It is gotta be a problem somewhere in the TXT-REMI-MIDI part because MIDI-REMI-TXT works as expected and w/o any issues.

Just in case, this is a post-processing issue/matter and AI is not involved here.

Samples.zip

from remi.

remyhuang avatar remyhuang commented on June 13, 2024

I suspect there may be something wrong with the "position" events or "bar" events. I recommend you to check the generated events yourself before converting to MIDI.

#############################################################################################
# WRITE MIDI
#############################################################################################
def word_to_event(words, word2event):
    events = []
    for word in words:
        event_name, event_value = word2event.get(word).split('_')
        events.append(Event(event_name, None, event_value, None))
    return events

def write_midi(words, word2event, output_path, prompt_path=None):
    events = word_to_event(words, word2event)
    print(*events, sep='\n') #this line

from remi.

asigalov61 avatar asigalov61 commented on June 13, 2024

Yes, thank you again so much for your help and advice. I double-checked everything and I, unfortunately, can't pinpoint the problem without investing a considerable amount of time and resources into debug/fixes.

Don't get me wrong, it very well may be my code as I am not a particularly talented coder but unfortunately I can only use/find useful implementations/code which works and also complete as I have mentioned earlier.

So please know that for now, I won't be able to utilize your tech/code, which is very disappointing as I think that your overall proposal is fantastic and has great potential.

I am very sorry about it and I really hope that you will find a suitable purpose for REMI. And please keep me in mind/posted about REMI updates/upgrades as I will be more than happy to give it another try.

Otherwise, great job, and you definitely going in the right direction with REMI.

Feel free to contact me if needed.

Most sincerely,

Aleksandr Sigalov

P.S. GPT2 did not produce any significant output due to this issue (at least on my end) and I always manually check everything, especially the dataset/encoding, so I am more than sure now that there is a problem with the code somewhere.

P.P.S and the only significant result with REMI was that AI loved it and i.e. the consistently achieved GPT2 model training loss was very low (~0.08-0.15) which is a very good sign and result IMHO.

from remi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.