Comments (22)
OK, I'll go ahead with a 3.0.0-beta.0 and we'll see how it goes. Thanks all.
from ember-radio-button.
Released as https://github.com/yapplabs/ember-radio-button/releases/tag/v3.0.0-beta.0
from ember-radio-button.
@gilest groups of buttons no longer worked at all, they acted independently and their actions wouldn't fire.
from ember-radio-button.
I'm no longer working on the project I had issues with so can't retest, though I'm starting to have a theory that it might have been due to either usage of string actions or a yarn bug that can happen when installing from a GitHub url.
from ember-radio-button.
@Benjy1979 I think ember install [email protected]
should do
from ember-radio-button.
I've been using 3.0.0-beta.0
in my app (Ember 4.6) and haven't run into any issues yet. Are there any remaining steps before the official release of 3.0.0
?
from ember-radio-button.
I think the issue is when a closure changed
action isn't provided, the expected native behavior doesn't work for apps that are still working through a mix of old and new syntax.
In v2, there was a computed-aware update to groupValue
-- the commented code is still present (but obviously won't work if uncommented):
ember-radio-button/addon/components/radio-button-input.js
Lines 16 to 20 in 732619a
I ran into this when a set of has-block RadioButton components provided neither the @name
argument nor changed
, and relied instead on responding to the update of groupValue
. Instead, clicking any of them persisted the current selection, and added the just-clicked input to the selection.
When I supplied the "name" argument, I got the expected "radio button" interaction (only one could be selected), but still didn't have the expected reactivity (since the component was using computed properties based on the value passed in as groupValue
).
When I provided the change callback, I was able to drive the reactivity as expected, through this.set
in the calling component. I am not currently able to test whether the change action is still optional, as that component is very firmly backed into computed properties at the moment.
from ember-radio-button.
Agree – @lukemelia would it be possible to cut a release? 🙇🏻
from ember-radio-button.
I tested latest master in our app and it was broken, might be worth adding some tests and doing some debugging before releasing.
from ember-radio-button.
What was broken? Just migrated an app from the older package ember-radio-buttons
(plural) to latest master
and didn't have any issues.
from ember-radio-button.
Any update of an ETA for the 3.X release? Thank you.
from ember-radio-button.
I'm happy to cut a release but need help confirming or fixing master's functionality.
from ember-radio-button.
@lukemelia What exactly seems to be the problem? I cloned the project and ran the tests and they all pass. Console is clean, no deprecation warnings or anything.
from ember-radio-button.
@lukemelia Just tested latest master on our project... nothing seems wrong. Works as expected. Am I missing something?
from ember-radio-button.
@gilest groups of buttons no longer worked at all, they acted independently and their actions wouldn't fire.
I didn't manage to verify this although I may not have tested all usages. Working in production for a client pinned at b2ab65f (latest master commit).
from ember-radio-button.
Thanks a lot, much appreciated!!
from ember-radio-button.
Please give it a whirl and let me know if it is working for you.
from ember-radio-button.
@lukemelia Just added this last update to our project. So far so good, tested a few of the places we're using radio buttons in, nothing out of the ordinary so far, no errors, no warnings. Passed it on to our QA to have a deeper look.
Also we have pretty good test coverage for our project and all of the tests pass.
from ember-radio-button.
Thanks for the update @vmoglan. Keep us posted here.
from ember-radio-button.
@runspired 👍 Thanks for following up.
from ember-radio-button.
@lukemelia perhaps my last update, our QA ran automated + manual tests and everything worked as expected. I think this may be good to go.
from ember-radio-button.
Hi,
how do I install version 3, as mentioned in the readme. When I read the guides it only really covers how to install npm or yarn packages. e.g ember install ember-cli-sass
What would I do with a zip file?
from ember-radio-button.
Related Issues (20)
- make keyboard navigable according to WCAG-A
- DEPRECATION: `hasBlock` is deprecated. Use `has-block` instead. HOT 4
- Where is Version 3 for Ember. 3.16? on EmberObserver? HOT 6
- Trying to upgrade to newer version
- multiple depreciations detected in 2.0.1
- `aria-checked` not being set on `master` branch HOT 3
- groupValue Documentation a bit confusing HOT 1
- Error: You cannot use `attributeBindings` on a tag-less component HOT 4
- <input> field isn't including a correct "value" attribute in the DOM in IE11
- autofocus attribute not supported HOT 1
- groupValue not updated on button deselect HOT 6
- Allow specifying a label using inline invocation HOT 3
- CRUD : Edit does not retain previous value HOT 2
- Upgrade ember-cli-htmlbars to remove deprecation warning HOT 3
- Question: What is this syntax in render of a test HOT 3
- aria-checked not used?
- Replace sendAction with closure actions HOT 10
- Remove `labeled-radio-button`
- How do I add data attributes to radio-button ? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-radio-button.