Giter Club home page Giter Club logo

Comments (2)

YannickRe avatar YannickRe commented on May 27, 2024

@davidosborneafton Thank you for sharing both your use cases! It makes it very clear what additional functionality you would like from this web part.

What you provide here:

  1. I'm afraid this might complicate things: what if this is toggled on and we also select Search Box instead of QueryString etcetc. This use case could potentially be solved with the PnP Modern Search search box which supports taking in the parameter, and passing it to the results web part. There is currently an issue with this approach, but if that's resolved, this approach would be "easier", I believe.
  2. For sure a good idea to make it a toggle. It's not too much work, so I'll keep this issue open until I have put it in the code.

from spfx-msgraph-peoplesearch.

YannickRe avatar YannickRe commented on May 27, 2024

@davidosborneafton An update:

  1. I have fixed #18 which resolves the issue with the PnP Search Box. My recommendation would be to use that component, and go like this Query String => PnP Search Box => dynamic connection to People Search. It's two components instead of 1, but it would resolve your use case and it doesn't complicate the code base further.
  2. I have included this toggle in the code directly.

I hope this can help you!

from spfx-msgraph-peoplesearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.