Comments (1)
SomeTroglodyte
commented on July 21, 2024
Why is MapUnit.destroy called from BaseUnit.shouldBeDisplayed? Again one of these evil virtual not-really-part-of-the-game-but-linked-into-the-map-anyway things? evil evil evil...
Ha! That code has been moved since and a comment added: // Expensive, since adding and removing the fake unit causes side-effects - yea causes side effects alright. We should find ways to do without fakeUnits, at least without fakeUnits that get their transients fully initialized. Same for Improvements.
...but that code is over 2 years old. So it's a new hidden side effect... Maybe look for a set of fakeunit helpers that ensure no side effects cascading into civ stats, cities, diplomacy or such get called? That would help but help cement a bad practice... Come to think of it, this is probably also the cause for the performance degrade reported elsewhere.
Ah, I see - the fakeUnit wasn't destroyed all those years up until #11745. Hmmm...
from unciv.
Related Issues (20)
- promotion will gives buff to All units when having <for [amount] turns>. HOT 1
- Outdated Mods HOT 1
- Crash after the city was founded HOT 3
- Modding Feature request: Adding "[Amount] Strength" As a alternative unique to "[RelativeAmount] Strength" HOT 1
- Unable to build stone works in city build on marble HOT 4
- "[amount] Unit Supply per [amount] population [cityFilter]" doesn't work HOT 2
- Promotion with one-time effect stacking even when unit already has that promotion HOT 5
- "Only available" not preventing unit upgrades
- FYI: Keeping up with kotlin and gradle versions HOT 2
- Politics table is empty HOT 1
- Mod images not showing up after update HOT 2
- 4.12.6 : Tile yields have crazy values - SOLVED in 4.12.6-patch1 HOT 4
- Incorrect diplomacy message HOT 1
- Feature request: .png files should be re-compressed with highest compression ratio to save space and bandwidth HOT 10
- Question Icons (game.png and game.atlas) HOT 5
- "Gain [amount] [stat]" not displaying full gain when stacked
- Feature request: Numbers Translation HOT 9
- Can't go to next round HOT 1
- Unlimited air units storage exploit
- Bangla Translations is broken in master! HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unciv.