City ambient sounds are not played in city screen about unciv HOT 4 CLOSED

Do you have a mod containing these sounds or only builtin from jar/apk? I've long suspected builtin regressed but never bothered to look closer. No need to answer, yes, fallback to internal is the root cause, so it works with that mod or running from source but not without mod and from apk/jar.

from unciv.

    /** Scans all mods [folder]s for [name] with a supported sound extension,
     *  with fallback to _internal_ assets [folder] */
    private fun getMatchingFiles(folder: String, name: String) =
        getMusicFolders(folder) { Gdx.files.internal(folder) }
            .flatMap {
                it.list { file: File ->
                    file.nameWithoutExtension == name && file.exists() && !file.isDirectory &&
                    file.extension in gdxSupportedFileExtensions
                }.asSequence()
            }

The comment is right - it falls back to internal per folder - but it needs to fall back per individual file. That should be covered by it being a Sequence and by then chaining Sequence transforms only, but - that idea breaks, likely because File.list() isn't a Sequence, Flow or Stream - or because the idea is flawed. Will need a little time to debug and decide.
(Can we switch from Gdx.files to java.nio? nio does have async folder listing...)
Will have other hard to detect negative consequences, too.

Wrong analysis. It's there but it's not the breadth-first vs depth-first thing..

from unciv.

Ah yes, sorry, I only connect now.

Built-in sounds and it was working a few versions ago (~ 4.80 I think).
I remember lowering the volume because of the modern era city sound which is kind of annoying with the continuous "honk-honk" (other ambient sounds are great though).

from unciv.

a few versions ago

Yes, I replaced the separate fork of MusicController (which is responsible for any audio that's streamed from storage instead of loaded in RAM) with an added track capability of the central MusicController - reusing existing "find" code.

"honk-honk"

Précisement! That was the trigger, especially as these files are meant for looping and as such have no gradual lead-in. So they needed the "fade" capability of MusicController. Still needs to follow pause-when-minimized though, that didn't come automatically and I forgot.

from unciv.