Giter Club home page Giter Club logo

Comments (7)

yairEO avatar yairEO commented on May 28, 2024

But it already decreases the number of suggestions as you type, so I don't understand how (1) will help much. it will also require another plugin which will make the code much much bigger..I'm trying to keep it as small (filesize) and performant as possible.

Your second suggestion seems the best because 2-3 minimum characters before showing the datalist will definitely decrease the number of suggestions shown.

I can't believe it actually makes your browser slow.. 330 (datalist options) is a very small number for a browser. Facebook has thousands of HTML elements and it's pretty smooth.
I didn't try so many myself but I will try today to load an English dictionary as my suggestions :) see how it behaves.

Regarding that arrow, it was only on Chrome and since I work with FF and I wanted chrome to look like FF I removed that arrow. the suggestions are shown anyway if you click on the input inside the Tagify, and users have to click on it anyway in order to type, so they will see the suggestions list no matter what, don't you agree?

Yes donations are welcome :) you can send it to my PayPal account:
[email protected]

I feel obligated to to open source community and try to work on my projects at night, after work, as much as I can, and I am happy people like you open issues for me. it means there is a demand for my work and it actually help others. I have another new project which I'm working on and will upload to Github next week.

from tagify.

ElvenDev avatar ElvenDev commented on May 28, 2024

Awesome!

The problem isn't that 330 is a lot of data. The problem is trying to show them all at once. Also, I just found out that since I pretty much only use chrome, that particular issue is only there.

image

So, just adding support to reduce the box (setting auto length, at least at chrome) also helps, since the user will have to type anyway. So I agree that maybe search box is unnecessary.

I personally disagree with an arrow. For me, I had to double click for it to show. While for me, developer and basically computer fanatic, it is not a problem, it might become an issue for those who are not (I have had to work with some for a while, so I have a bit experience). So, adding dumb-user support (arrow), just to show that "If you click here, you can open all suggestion list!", will help a lot and make the user experience better. Sometimes if user see the input, they do not click immediately as they do not know what it is. Arrow however screams "CLICK HERE!"!

from tagify.

yairEO avatar yairEO commented on May 28, 2024

Chrome has a known bug regarding that:

https://bugs.chromium.org/p/chromium/issues/detail?id=375637

it would help if you "star" the bug (sign in and then click the ☆ on the left side) so they will give it higher priority and it might be fixed soon.
Firefox shows a scrollbar correctly so the list is never too long, but I will implement your second idea so the list will not be shown until a minimum number of characters were applied

from tagify.

ElvenDev avatar ElvenDev commented on May 28, 2024

Apparently, ios safari also shows full list too.

I personally think it is a wrong approach to "Wait for official bug fix somewhere", what might be fixed in 10 years. Meanwhile, our consumers must use bugged version. But I guess I can try to apply a third-party myself for now :).

Thank you for the minimum characters idea. Make sure to add an option to enable/disable it or set minimum character amount, so people can set it to show straight away if data amount is small.

Also, I still recommend adding arrow into all 3 browsers.

Thank you!

from tagify.

yairEO avatar yairEO commented on May 28, 2024

yes Safari is webkit and Chrome is also webkit, they use the same browser engine which inherits the same bugs. they wrote in the bug that it will be fixed very soon, probably matter of weeks I hope. I don't know how to add the arrow to FF, because that is something which is specific for webkit browsers, but it's easy to return that arrow, you just need to edit the CSS and bring it back. remove the line where I hide it.

from tagify.

ElvenDev avatar ElvenDev commented on May 28, 2024

Yes, already done that :).

from tagify.

ElvenDev avatar ElvenDev commented on May 28, 2024

Thank you!

from tagify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.