Errors during action handlers about dispatchr HOT 5 CLOSED

Handling this better would be very nice - I have to try/catch while debugging because exceptions (from my code) get swallowed by the Dispatchr error handling mechanism. Guidance on best practices would be appreciated!

from dispatchr.

Ok, so most of this stems from the fact that we're not resetting currentAction after a thrown exception. Perhaps we can add a try/catch/finally to the execute method to ensure that it gets reset.

from dispatchr.

@mridgway this is hopefully what's achieved in #47.

M

from dispatchr.

I'm not sure that we need to differentiate the internal errors with the store's errors in this case. Both should still throw, but they should be able to be handled by the caller to dispatch. Also, I think in your implementation the this.currentAction wouldn't get reset since throw would exit the flow.

Here is my proposal for fixing this: 66f5355

from dispatchr.

Yup, you're right! That looks spot on.

M
On 12 Jan 2015 20:56, "Michael Ridgway" [email protected] wrote:

I'm not sure that we need to differentiate the internal errors with the
store's errors in this case. Both should still throw, but they should be
able to be handled by the caller to dispatch. Also, I think in your
implementation the this.currentAction wouldn't get reset since throw
would exit the flow.

Here is my proposal for fixing this: 66f5355
66f5355

—
Reply to this email directly or view it on GitHub
#46 (comment).

from dispatchr.