Element is always marked as changed, also if it's not about carrierwave-base64 HOT 8 CLOSED

Investigating the issue a little further gave the following result:

When there is a file already available for :string_upload, then the textarea field has the content file.png.

• When submitting it with this value, then an UPDATE is triggered.
• When submitting it empty, no UPDATE is triggered.

Is this a problem on the form's side now or on your side?

I generally think your gem should be a little more picky about the submitted values: only a valid base64 string or an empty value should be treated as valid; others should add a validation error like invalid format or so.

from carrierwave-base64.

For the time being, I simply do f.input :string_upload, as: :text, value: nil, which does the trick. Yet, I think it's not really the solution to the named problem.

from carrierwave-base64.

Sorry, haven't got a time to look at it. Will try to do it on this week

from carrierwave-base64.

Seems that my workaround with setting value to nil breaks the possibility to remove the file with carrierwave's remove_xxx checkbox input.

Thanks for looking into it.

from carrierwave-base64.

After taking a closer look at the problem you described, here is what i think:

Showing the persisted file name in a base64 text input field makes no sense, since it is not a base64 encoded image data. Setting the input value is the most correct way i can think of to deal with the problem you have.

The functionality with removing stored uploads should not be broken by the nil value for the input field. Maybe it is something more app specific? If you could provide me some details on the error, i would be glad to help.

I also added a spec for uploads removing functionality:
https://github.com/lebedev-yury/carrierwave-base64/blob/master/spec/adapter_spec.rb#L46

from carrierwave-base64.

Thanks for helping. I will take another look at my app next week and provide you with details, if necessary.

Have a nice weekend! :)

from carrierwave-base64.

thanks, you too :)

from carrierwave-base64.

@jmuheim: I will close this issue for now, if you still have problems with that, just open it again

from carrierwave-base64.