Giter Club home page Giter Club logo

Comments (3)

larryhastings avatar larryhastings commented on May 30, 2024 1

I spent some time investigating this. tl;dr: you can ignore it, and it would probably be better if the tool didn't print the error message.

First of all, the slash has nothing to do with it. It's added as part of the error message:

logger.info("No url found: {bundle_title}/{product_title}" [...]

It's not part of the product name, it's not confusing the tool internally. That's not what's going on.

Here's what's going on. For every "product", the tool downloads a blob of JSON information. That blob includes a list of downloadable things called the "download_struct". Most of the time, the entries on that list identify an individual file the tool can download--its URL, its MD5 and SHA1 checksums, a timestamp, and its size in both human-readable and machine-readable forms. But sometimes one of these entries will contain other stuff that has nothing to do with directly downloading a file. For example:

  • "World Of Goo Soundtrack" has an entry linking to a web page where you can download the soundtrack for free.
  • "Dustforce" has some sort of list of ".js" and ".ogg" files in an "asm_manifest"--maybe a Javascript soundtrack player?
  • "Costume Quest" has an entry linking to a web page explaining which APK you should select for side-loading.

Every one of these I've looked at has legitimately been something the tool can safely ignore. And in particular, every one has had a "human_size" set to "0 bytes", which seems like a hint in the JSON that there's nothing for the tool to download from this entry. Also, in every case, I found that the product that displayed this error message did download the product. For example, I got this error for both "Dustforce" and "Costume Quest", yet both products downloaded fine.

I'm going to submit a PR suppressing this error message when the "human_size" is "0 bytes". But for now I believe you can safely ignore these warnings.

from humblebundle-downloader.

warthog9 avatar warthog9 commented on May 30, 2024

So I ran into this too and started looking at it. Something on the download page doesn't return a downloadable link, and thus the "no url found", however the way this bails isn't that it stops for that product it cycles to the next item and keeps looking. I believe this is LIKELY an ignorable warning, though you should double check those. I don't believe this actually needs to be resolved (though maybe the message could be improved some?)

from humblebundle-downloader.

mhalano avatar mhalano commented on May 30, 2024

I downloaded World Of Goo and Osmos correctly, but I had to stop and start again the download (network outage). In the second execution, this error occured.

from humblebundle-downloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.