Giter Club home page Giter Club logo

Comments (3)

dosubot avatar dosubot commented on August 20, 2024 3

Yes, you can modify the resolve method in Image.java to first check for the subid image and only fall back to the default image if the subid image is not found. Here is the modified resolve method:

public static Image resolve(String id) {
    String subid = XTFConfig.get("xtf." + id + ".subid");
    Image image = Image.get(id + "." + subid);
    
    if (image == null) {
        image = Image.get(id);
        if (image == null) {
            throw new UnknownImageException("Unable to get image using " + id + " or " + subid);
        }
    }

    String customReg = XTFConfig.get("xtf." + id + ".reg");
    String customRegId = XTFConfig.get("xtf." + id + ".regid");
    String customUser = XTFConfig.get("xtf." + id + ".user");
    String customTag = XTFConfig.get("xtf." + id + ".tag");

    String reg = customRegId != null ? XTFConfig.get("xtf.registry." + customRegId) : customReg;
    reg = reg != null ? reg : image.getRegistry();
    String user = customUser != null ? customUser : image.getUser();
    String tag = customTag != null ? customTag : image.getTag();

    return new Image(reg, user, image.getRepo(), tag);
}

This modification ensures that the method first attempts to resolve the image using the subid and only falls back to the default image if the subid image is not found [1].

To continue talking to Dosu, mention @dosu.

from xtf.

mnovak1 avatar mnovak1 commented on August 20, 2024

I'm ok with this change. Current logic seems to be wrong.

from xtf.

mchoma avatar mchoma commented on August 20, 2024

@dosu what do you think?

from xtf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.