Comments (3)
Yes, you can modify the resolve
method in Image.java
to first check for the subid image and only fall back to the default image if the subid image is not found. Here is the modified resolve
method:
public static Image resolve(String id) {
String subid = XTFConfig.get("xtf." + id + ".subid");
Image image = Image.get(id + "." + subid);
if (image == null) {
image = Image.get(id);
if (image == null) {
throw new UnknownImageException("Unable to get image using " + id + " or " + subid);
}
}
String customReg = XTFConfig.get("xtf." + id + ".reg");
String customRegId = XTFConfig.get("xtf." + id + ".regid");
String customUser = XTFConfig.get("xtf." + id + ".user");
String customTag = XTFConfig.get("xtf." + id + ".tag");
String reg = customRegId != null ? XTFConfig.get("xtf.registry." + customRegId) : customReg;
reg = reg != null ? reg : image.getRegistry();
String user = customUser != null ? customUser : image.getUser();
String tag = customTag != null ? customTag : image.getTag();
return new Image(reg, user, image.getRepo(), tag);
}
This modification ensures that the method first attempts to resolve the image using the subid and only falls back to the default image if the subid image is not found [1].
To continue talking to Dosu, mention @dosu.
from xtf.
I'm ok with this change. Current logic seems to be wrong.
from xtf.
@dosu what do you think?
from xtf.
Related Issues (20)
- Ideas - Refactor XTF to better handle running tests in separate namespaces
- Non-GA OCP versions not being matched HOT 1
- No fallback when OCP version does not match
- StartupProbes support
- XTF does not support custom Kubeconfig with cert/key file for OpenShiftBinary HOT 15
- XTF code formating
- Is BuildManager wrongly creating a system:image-puller RoleBinding?
- Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]
- Impsort plugin fails with Maven 3.9.1
- configMapKeyRef and secretKeyRef: name and key are inverted HOT 2
- executeWithBash: add logs
- CLIUtils.executeCommand() log on debug level command and it output in case of success HOT 1
- Update xtf-maven-release.yml GH Action not to use "-Prelease" when pushing into branch
- Stop raising illegalArgumentException when no pod found in #getAnyPod
- Replace load().get() with load().item()
- ClusterVersionOpenShiftBinaryPathResolverTest failing because of changed oc location HOT 1
- mcr.microsoft.com/mssql/rhel/server:2022-CU13-rhel-9.1 should have one or two '/' HOT 2
- /opt/mssql-tools/bin/sqlcmd: not found in mcr.microsoft.com/mssql/server:2022-latest HOT 2
- Dynamically find out git repo of current repo from .git folder
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xtf.