Giter Club home page Giter Club logo

Comments (5)

xtaci avatar xtaci commented on August 23, 2024

but the file descriptor in the original net.Conn has been closed when watching , the working fd in watcher is dup() -ed from net.Conn.

from gaio.

liukun avatar liukun commented on August 23, 2024

Yes, it is. You can recover net.Conn by:

	f := os.NewFile(uintptr(fd), "dup-fd")
	conn, err := net.FileConn(f)
	_ = f.Close()
	return conn, err

from gaio.

xtaci avatar xtaci commented on August 23, 2024

that makes sense, could you submit a PR to this issue for me to review the details?

from gaio.

liukun avatar liukun commented on August 23, 2024

Cool! I'll submit one when I have time.

不过有个设计上的问题。我目前是在回调里用size这个属性把fd传回来的。这样能接受吗?还是在OpResult里增加一个专用的FileDescriptor int或者通用的IntValue int呢?

from gaio.

xtaci avatar xtaci commented on August 23, 2024

A watcher.Detach(conn) func is preferred.

from gaio.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.