Comments (11)
@NaincyKumariKnoldus, the repository is not mine. It's up to @xpqz to decide. He probably won't mind if you send him a PR.
from cultivations.
Hi @NaincyKumariKnoldus annd @AleBeda -- and thanks for taking the time.
It's in fact the first result that's wrong; I was relying on ⎕IO being defaulted to 1 when you open a new session in a notebook, but the build system that makes the book has an IO-setting that 'spills over' from an earlier chapter. The last ⎕IO←1
in the section you highlight is simply to return to the default. I'll make it clearer.
For future reference, the HTML pages are auto-generated from the Jupyter notebooks that make up the source for the book; thus any PRs would need to target those, as any changes to the HTML pages will get overwritten next time I run jupyter-book build
. See https://jupyterbook.org/basics/build.html for details on how that works.
from cultivations.
Hey @AleBeda I would love to do this. Can I?
from cultivations.
okay @AleBeda sure I am doing it.
from cultivations.
Hey @xpqz and @AleBeda I have raised PR for this. Please review this.
Thanks!
from cultivations.
Okay! @xpqz You mean to say I have to change first result not second result. Right?
from cultivations.
That was my intention, but it works doing it like so, which should be immune to this problem:
⍳4 ⊣ ⎕IO←0
⍳4 ⊣ ⎕IO←1
from cultivations.
okay I am changing first result. Correct?
from cultivations.
I've fixed it already this time. But as I said, your PR would have needed to target the notebook itself
Fixed in 142e6af
from cultivations.
Means ......I havent understand.
from cultivations.
So assuming you're not familiar with jupyter and jupyter-book....the book is built from jupyter notebooks and the Dyalog jupyter kernel. The website's html is automatically generated, and need never be modified manually.
The notebook in question is this:
https://github.com/xpqz/cultivations/blob/main/contents/SystemFunctions.ipynb
Any changes to the book's content text, code examples etc always go in the notebook files (contents/*.ipynb
). The _build/html/*.html
files are build artefacts only -- they're generated by the jupyter-book build contents
command.
Whilst the notebooks themselves are basically just a bunch of json, they're not intended to be edited directly. Instead, in order to make changes to the notebooks you need the following bits and bobs installed:
- Jupyter itself (https://jupyter.org/)
- the Dyalog jupyter kernel (https://github.com/Dyalog/dyalog-jupyter-kernel)
- the jupyter-book authoring system (https://jupyterbook.org)
With that in place, you can edit directly in a web browser, crucially including executing APL code in place.
Your PR changes the build artefacts, not the source. Instead, had you changed the notebook source, the build process would have executed the APL snippet, and included the (correct) output into the generated html.
Don't let this put you off: you spotted a problem, reported it, and it got fixed. Play around a bit with the jupyterbook system; it's a super-cool tool chain to do this kind of thing with.
from cultivations.
Related Issues (14)
- C7: non-bool ⍺ example for partitioned enclose
- C7: partitioned enclose abbreviated ⍺ HOT 1
- C7: partitioned enclose head/tail example HOT 1
- C7: additional .NET example for monadic ⌷
- Addition, lesson 1
- Issues for the SystemFunctions chapter
- More on the Constants chapter HOT 1
- Regex changes
- Issues in ⊥ chapter
- Typo in "Lookup without replacement"
- Issue on page /UserCommands.html
- Issue on page /PDI.html
- PDF of the entire book
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cultivations.