Comments (4)
Patch on master (v3), backport to v2 branch
from felicity.
@WesTyler Hey found some time to take a look at this.
Findings:
Seems like options
weren't being passed in here, and here
So when we got here includeOptional
was undefined
It's late, couldn't muster up enuff juice to write some tests
from felicity.
Awesome, thanks! I'm trying to wrap up our hapi 17 stuff, but I'll post here when I get started on this. Feel free to make a PR if you beat me to it! Thanks for digging in :D
from felicity.
Backported to the v2 branch and released in [email protected]
Thanks again @samueljoli
from felicity.
Related Issues (20)
- felicity.example() throws an error for Joi.object().default(<OBJECT>) HOT 3
- Example with bool type throws HOT 4
- .example() on string().required().valid(a, b, c).default(b) does not take default into account HOT 3
- Respect .strip() in entityFor constructors
- Joi.func() creates Objects as examples HOT 3
- instance validation fails silently when nested array items do not pass validation. HOT 3
- A bunch of questions and feature suggestions :-) HOT 3
- 3.0.0 Release Notes
- Default `stripUnknown` on entityFor Constructor input leads to weird behavior
- Investigate - nested optional props in a required object
- Investigate - Node@10 regex support for generating examples using lookaround assertions
- Update to Joi 14 HOT 6
- Update hapi core modules HOT 1
- TypeScript support HOT 1
- Plans to support Joi 16 HOT 11
- Joi the max() validation is not respected.
- Does not support Joi's array().has(...)
- Invalid mock returned if schema uses any.when
- Typescript support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from felicity.