Giter Club home page Giter Club logo

Comments (5)

hoodoos avatar hoodoos commented on August 16, 2024

Guys, dunno if it's correct, but seem to work for me.
https://gist.github.com/725268

I'm not sure how to push it, so tell me if it's correct patch I'll figure it out.

from node-expat.

astro avatar astro commented on August 16, 2024

So far, expat yields cdata as text. Isn't that enough? How do you want to handle cdata other than text?

Your proposed patch adds just the events, while cdata is still emitted as text. How are you going to deal with that? I just want to understand before I merge the code.

Also, how would you like to be mentioned in the contributors field of package.json?

from node-expat.

hoodoos avatar hoodoos commented on August 16, 2024

In my saxparser wrapper I use flag isInCdata using new methods for setting/unsetting it and then check it on 'text' event to fire my internal onCharacters or onCdata.

Pleast check it carefuly, it's my first cpp code ever.
I'm not pretending for it, but won't act against it either :)

from node-expat.

astro avatar astro commented on August 16, 2024

Thanks, it's included in node-expat 1.2.0.

Please notice that I renamed the events from startCdataElement/endCdataElement to startCdata/endCdata because CData sections are no XML elements and it's shorter.

from node-expat.

hoodoos avatar hoodoos commented on August 16, 2024

They're so called in expat itself, well doesn't matter really. Thanks a lot!

from node-expat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.