Comments (2)
I'm a bit unclear on this as is. I know Xero's endpoints sometime swap the functionality for PUT and POST as to what would be expected.
Just based on docs we seem to use:
PUT Payments
Use this method to apply payments to approved AR and AP invoices or refund AR or AP credit notes.
put:
security:
- OAuth2: [accounting.transactions]
tags:
- Accounting
operationId: createPayments
POST Payments
Use this method to delete (reverse) payments to invoices, credit notes, prepayments & overpayments. Note that payments created via batch payments and receipts are not supported. Payments cannot be modified, only created and deleted.
post:
security:
- OAuth2: [accounting.transactions]
tags:
- Accounting
operationId: createPayment
Are you proposing renaming the POST
function to updateOrCreatePayments
?
I think that it is a breaking change for what I'm not sure is possible. I'd have to triple check but wasn't sure if you can update existing, past the soft delete
.
from xero-openapi.
What I'm wanting is to be able to delete multiple payments in one call. Xero's POST endpoint is used for this purpose, but the open API currently defines createPayment
as the POST action. My understanding was the open API doesn't support multiple actions for the same endpoint and method, which is why defining a separate deletePayments
POST action is not possible, is that correct?
So what I'm suggesting is that the createPayment
action is redundant and could be replaced with a different action for bulk deletion. The name updateOrCreatePayments
was simply a suggestion for consistency with other similar actions, if you wanted to keep the ability to create as well. (But you're right, the only 'update' possible is to set the status to deleted)
Yes, it would be a breaking change but it would open functionality which is currently possible.
from xero-openapi.
Related Issues (20)
- Missing POST BatchPayments
- Collect HOT 1
- Get Invoices paging with IDs HOT 6
- Couldn't create Credit Card account through XERO Accounting API HOT 1
- Github actions test issue HOT 1
- Another github action test with account outside of org HOT 1
- Actions test HOT 2
- more testing HOT 2
- test test test HOT 2
- test
- test HOT 2
- Create Invoice is missing eInvoicing Field HOT 2
- Country in Organisation Address HOT 1
- Unable to build Go SDK from OpenAPI (failures in accounting schema) HOT 4
- Asset Type definition inconsistent with Xero interface HOT 2
- Asset depreciationStartDate not setting HOT 2
- Empty array with status 200 is returned when calling /connections endpoints HOT 4
- AU Payroll API LeaveApplicationID changes when a request is in Scheduled status HOT 3
- LineItems: DiscountRate returned but DiscountAmount does not depending on invoice call query HOT 2
- Organisation Class enum values need updated HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xero-openapi.