Comments (1)
Found a problem of using interface for services, when using middleware, what is passed to the makeServiceEndpoint
is actually the middleware with original service wrapped inside it, i.e.
var svc StringService
svc = stringService{}
svc = loggingMiddleware{logger, svc}
svc = instrumentingMiddleware{requestCount, requestLatency, countResult, svc}
One way to solve it is to use another struct for the service, i.e. StringServiceFactory, which must implement makeEndpoint
and decodeRequest
and another interface which only requires UpperCase
, thus all the middleware just need to implement the logic around UpperCase
and don't need to implement makeEndpoint
and decodeRequest
Another way is to add nop methods to satisfy the interface
from xephon-k.
Related Issues (20)
- Tags in series are passed by reference not value
- Support Protocol Buffers
- Replace sort.Sort with sort.Slice
- Unmarshal IndexEntries is empty
- Data File Writer HOT 1
- Data File Reader HOT 1
- Data File Encoding Timestamp and Value HOT 1
- GoDoc chose comment generated by protobuf as package documentation HOT 1
- Columnar format in memory representation for series HOT 1
- Config Docker volume HOT 1
- Gogland refactor messed up the doc HOT 2
- Remove go-kit
- Config file and Refactor `cmd`
- One server got error while another is not started cause nil pointer HOT 1
- storage memory concurrent map write HOT 1
- Basic benchmark disk size increased from 8M -> 19M HOT 3
- Clean up code for BenchHub
- [go][dep] Init new codebase
- [mem] In memory store for data
- [reboot] Add dev log and roadmap
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xephon-k.