Giter Club home page Giter Club logo

Comments (9)

pke avatar pke commented on May 10, 2024 2

Thats because start exported from the hook is unstable. Its changing after every render. When eslint complains that it needs to be part of the useEffect dependency array, just ignore this warning. The dependency array must only contain canStart like the example code shows. It started to work flawlessly then.

  // this works
 React.useEffect(() => {
    canStart && start()
  }, [canStart])

  // This makes eslint happy but causes infinite render loops
 React.useEffect(() => {
    canstart && start()
  }, [canStart, start])

I am still suspicious of libs that don't export stable functions from their hooks what other re-render problems they may cause.
@xcarpentier any idea why the function is not stable?

from rn-tourguide.

sarath40158 avatar sarath40158 commented on May 10, 2024 1

@mcanikhilprajapati can you provide some code for this ?

from rn-tourguide.

mcanikhilprajapati avatar mcanikhilprajapati commented on May 10, 2024

same i am facing

from rn-tourguide.

mcanikhilprajapati avatar mcanikhilprajapati commented on May 10, 2024

try to add context on top of all function

from rn-tourguide.

HaiyangZhang1994 avatar HaiyangZhang1994 commented on May 10, 2024

try to add context on top of all function

Have same problem, could you please share more info?

from rn-tourguide.

sarath40158 avatar sarath40158 commented on May 10, 2024

Any one having same issue 👍
I have fixed this by moving from top level to
Other Entry File of the App flow

Just try by changing from top level to to wrapping up to any of entry file Like

  • Home Screen or IntroScreen or LoginScreen

from rn-tourguide.

alphacodedev99 avatar alphacodedev99 commented on May 10, 2024

Hello i have same problem, pls if someone can help me, add on Discord: Alpha Tica#7499, and help me to fix my app, i have short deadline.. tnx in advance

from rn-tourguide.

surbhitrao avatar surbhitrao commented on May 10, 2024

I was also having the same issue. I had to use TourGuideZoneByPosition in place of TourGuideZone.
I'd recommend using Dimensions to find the exact position of the tour overlay.

Use the TourGuideZoneByPosition after importing like this

const { canStart, start, stop, eventEmitter, TourGuideZoneByPosition, tourKey, } = useTourGuideController();

And not
import { TourGuideZoneByPosition, useTourGuideController, } from 'rn-tourguide';

from rn-tourguide.

renatomserra avatar renatomserra commented on May 10, 2024

Having the same issue trying to set a guided tour on an element in a TopNavigator element, the lib was working so perfectly everywhere else :(
Even with TourGuideZoneByPosition it fails as soon as i add the prop isTourGuide with the same error

from rn-tourguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.