Comments (9)
Thats because start
exported from the hook is unstable. Its changing after every render. When eslint complains that it needs to be part of the useEffect
dependency array, just ignore this warning. The dependency array must only contain canStart
like the example code shows. It started to work flawlessly then.
// this works
React.useEffect(() => {
canStart && start()
}, [canStart])
// This makes eslint happy but causes infinite render loops
React.useEffect(() => {
canstart && start()
}, [canStart, start])
I am still suspicious of libs that don't export stable functions from their hooks what other re-render problems they may cause.
@xcarpentier any idea why the function is not stable?
from rn-tourguide.
@mcanikhilprajapati can you provide some code for this ?
from rn-tourguide.
same i am facing
from rn-tourguide.
try to add context on top of all function
from rn-tourguide.
try to add context on top of all function
Have same problem, could you please share more info?
from rn-tourguide.
Any one having same issue 👍
I have fixed this by moving from top level to
Other Entry File of the App flow
Just try by changing from top level to to wrapping up to any of entry file Like
-
Home Screen or IntroScreen or LoginScreen
from rn-tourguide.
Hello i have same problem, pls if someone can help me, add on Discord: Alpha Tica#7499, and help me to fix my app, i have short deadline.. tnx in advance
from rn-tourguide.
I was also having the same issue. I had to use TourGuideZoneByPosition in place of TourGuideZone.
I'd recommend using Dimensions to find the exact position of the tour overlay.
Use the TourGuideZoneByPosition after importing like this
const { canStart, start, stop, eventEmitter, TourGuideZoneByPosition, tourKey, } = useTourGuideController();
And not
import { TourGuideZoneByPosition, useTourGuideController, } from 'rn-tourguide';
from rn-tourguide.
Having the same issue trying to set a guided tour on an element in a TopNavigator element, the lib was working so perfectly everywhere else :(
Even with TourGuideZoneByPosition
it fails as soon as i add the prop isTourGuide
with the same error
from rn-tourguide.
Related Issues (20)
- Multiple tours in the same component HOT 1
- [Android] dismissOnPress doesnt work. HOT 1
- Forcing tooltip to appear at the bottom of the TourGuideZone HOT 1
- Text of next step already briefly visible when going to next step HOT 1
- "undefined is not an object" when tour has ended HOT 2
- no props for changing background color for the modal of rn-tourguide(skip,previous,next) HOT 1
- Does not work with react-native's modal component HOT 6
- Optional loading of the Tourguide Controller
- Fading tooltip text
- How to highlight bottom tab from react navigation? HOT 1
- TypeError: Cannot read property '_nativeTag' of null
- web support with expo-sdk >= 48 HOT 1
- Restarting the guide HOT 1
- Passing tourKey to useTourGuideController returns undefined eventEmitter HOT 5
- Mutiple pages tours not running
- issue of tour guide rendering while showing tour in scrollview.
- ERROR while scrolling back outside the refferred scrollview HOT 4
- Android dark mode is switching the text color to white HOT 4
- Multiple screens Issue HOT 1
- Different tours on the same screen and same component does not work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rn-tourguide.