[Update] script.tag-generator about repo-scripts HOT 21 CLOSED

Click on fork, then grab the url to your repo should be https://github.com/YOURNAME/repo-scripts.git

Clone it to your local machine (I think you know how), switch to the target branch for your addon, in this case probably krypton as I think this is a new submission. Then just copy a version of your addon into the folder your in. You want delete the .git folder of the addon folder you just copied just in case, then just add everything and commit it with the message [script.tag-generator] 0.0.5. Then you want to push to a new branch with some name you choose, like add-tag-generator for example.

If you've done all that, just come back to the repo here: https://github.com/xbmc/repo-scripts and there should be a very obvious button to create a pull request. Click it, then you'll get a window where you choose the base and the head. The base needs to be xbmc/krypton the head YOURGITHUBNAME/add-tag-generator
Fill in the data and submit it.

from repo-scripts.

The news in your addon.xml should only include the latest change

from repo-scripts.

The wiki was not explicit about that. See wellspokenman/tag-generator@522e01a

from repo-scripts.

@wellspokenman thanks for letting me know, I just updated the wiki

from repo-scripts.

Thank you. I've updated the issue with the new commit presenting only the most recent changes in news.

from repo-scripts.

Can you also change "en" here to "en_GB"
https://github.com/wellspokenman/tag-generator/blob/master/addon.xml#L14-L15

from repo-scripts.

Done. Updated issue with new commit.

from repo-scripts.

Also, if there's any reading on how to do a proper pull request, I'd appreciate being pointed in the right direction.

from repo-scripts.

Any specific part you're struggling with? Which operation system are you using

from repo-scripts.

I use windows and linux to interact with the git command line, but I only ever use add/commit/checkout/status/log. I assume that a pull request is a request to pull my code into the master Kodi branch, that offers line by line review/compare for the approver? But I am both unsure of where to find my addon inside the main repo, and unable to use the git website to choose the tag-gen repo to compare against this (seems to be made for comparing different branches within the same repo).

from repo-scripts.

hmmm. Tried a couple of times without luck. I clone, checkout krypton, copy my files, add, commit, then try to push my commit to a new branch, but that's where it breaks.
x@x:~/Downloads/kodi-fork$ git push -u origin "add-tag-generator"
error: src refspec add-tag-generator does not match any.

from repo-scripts.

the origin remote is configured to be this? https://github.com/wellspokenman/repo-scripts

from repo-scripts.

that did it - thanks very much for teaching me. Added a new remote, checked out new branch and pushed to the new remote. Both firefox and chrome have a panic attack (30% CPU + 4gb ram) when I try to push that new compare button, but I guess I can just leave this issue open and do a PR when I release 0.6.

from repo-scripts.

Just checking: this is in the queue, right? I know I confused matters by asking about how to do a PR, but I assumed it was still allowed to submit this version via an issue.

from repo-scripts.

Oh, sorry, I thought you would be creating a PR by yourself :)
I will prepare something in the next days.

from repo-scripts.

Would be cool, if you could:

• Remove all *.pyo files from your repo
• Reference dependencies in addon.xml instead of inlining the whole code. Should work for six, requests and simplejson (you already do it for simplejson so you actually get that part two times https://github.com/wellspokenman/tag-generator/blob/master/addon.xml#L8)

Just add:

    <import addon="script.module.requests" version="2.12.4"/>
    <import addon="script.module.six" version="1.9.0"/>

The others haven't been moved to modules yet, unfortunatly.

from repo-scripts.

Sorry for the delay, real life did it's thing for a while there. New commit 1be8876 submitted. wellspokenman/tag-generator@1be8876

from repo-scripts.

Any progress here?

from repo-scripts.

Did you know that today is our three month anniversary? Seems like only yesterday.

from repo-scripts.

Seems like you still have simplejson and requests included in your addon?
These shouldn't be needed due to the dependencies you set in the previous commit. https://github.com/wellspokenman/tag-generator/tree/master/resources/lib

Edit: Six is also still there

from repo-scripts.

Those modules are used by Trakt, they need to be available outside of Kodi.

from repo-scripts.