Comments (10)
Hi,
I'll look into it this afternoon.
Thanks for the heads up.
Quite strange the file is larger... I've only changed the value of an enum
in xbim to handle voids differently.
Claudio
On 29 Jul 2015, at 23:24, Andy Ward [email protected] wrote:
@martin1cerny https://github.com/martin1cerny , just a heads up, this may
be one for you or it may be one for @CBenghi https://github.com/CBenghi
It looks like there's been a change in how we're handling openings in the
Geometry Engine (possibly this change:
e63ad958e9edfa158834fe50775c7b8bd2bacf64) - which is causing the
xbim-viewer[...].js to throw an exception during parsing of the wexbim file.
Repro
Using Xbim.Geometry 3.1.3 from Myget/develop, and the latest XbimWebUI
(pre-release from myget)
Take any Model with an opening(e.g. OneWallTwoWindows.ifc) and you'll get
error on the console at this line:
If you use a wexbim generated from the latest Nuget Xbim.Geometry it's
fine.
I'll see if I can track it back to a particular change but it may be a few
days before I can look at it. I put a spot fix in to skip the problem items
and you see something like this:
[image: image]
https://cloud.githubusercontent.com/assets/923699/8971341/5c06b2fe-3647-11e5-9210-82d8c5fd9ac8.png
Left is latest Geometry (Myget 3.1.3). Right is the old Geometry (Nuget
3.0.21). Both are the same source model file and XbimWebUI code. The only
difference is the version of Xbim.Geometry used to generate the webxbim.
Might be worth speaking to Claudio to see what the intention is with the
above change. The newer wexbim is larger so I'm assuming it contains extra
records (intentionally, or unintentionally).
Loading the new (and old) xbim files into XbimXplorer renders OK
Sounds like either:
- WebUI needs to handle the new entries or
- The Xbim3DModelContext Serialiser needs to strip them out during
wexbim serialisation
—
Reply to this email directly or view it on GitHub
#26.
from xbimwebui.
@CBenghi Did you get any further with this? Still seeing the issue with latest develop code.
from xbimwebui.
@andyward I'm sorry I didn't catch on this before. Thanks for the heads up. But it seems it is a bug in XbimGeometry or XbimIO rather than in WeXplorer. It just indicates that the wexbim file is wrong which is apparently true. I also wonder if @CBenghi got any further.
P.S.: It is interesting that most issues raised on GitHub in XbimWebUI project are related to different parts of xBIM :-)
from xbimwebui.
I did a bit a investigation into this. There are actually two issues.
- The WexBIM contains shape definitions that reference products not listed in the products list. Notably IfcOpeningElement geometry is coming though, but the elements are not.
- The WexBIM file contains duplicate geometry where there has been cutting. E.g. A wall will have geometry for before and after any opening.
So after resolving the first issue you get:
not
Using OneWallTwoWindows.ifc as a test case I added some diagnostics using Geometry 3.0.23 and the latest Develop.
We have the same 3 products (1 Wall and 2 Windows), but three extra shapes (# 5-7). Shape 6 is the uncut wall, while 5&7 are the openings with no product reference.
Hope that helps you @CBenghi
Andy
from xbimwebui.
Hi Andy,
I think I have a solution to post, but I'm currently travelling overseas,
I'll post it as soon as I get a sound connection for you to test.
I'm not really strong on the web viewer, to be sure it's all right.
Also I think the wexbim format should be enriched. At the moment it cannot
differentiate between model shape types.
Claudio
from xbimwebui.
Hi Andy,
I've posted a couple of changes to Geometry that should fix this problem, but I don't know enough of the webviewer to understand how it ever worked before them...
Can you please double check?
Thanks,
Claudio
from xbimwebui.
Hi Claudio
Has the Geometry fix been published to Nuget / MyGet
If so I can test this fix
Thanks
Darren
On 29 August 2015 at 14:31, Claudio Benghi [email protected] wrote:
Hi Andy,
I've posted a couple of changes to Geometry that should fix this problem,
but I don't know enough of the webviewer to understand how it ever worked
before them...
Can you please double check?
Thanks,
Claudio—
Reply to this email directly or view it on GitHub
#26 (comment).
from xbimwebui.
Hi Darren,
yes it's been uploaded under the develop branch.
You will find the nuget package in the myget develop repo.
https://www.myget.org/F/xbim-develop/api/v2
Best,
Claudio
from xbimwebui.
@CBenghi Nice work! Looks to have fixed the issue 👍
Note for anyone else - I used 3.1.10-V00006
I guess we need to discuss if we ever want these geometries in a wexbim at some point. My gut feel is to wait until we find a need since we want to keep the wexbim payload a light as possible.
from xbimwebui.
Closing
from xbimwebui.
Related Issues (20)
- If the viewer is assigned to data in vue, an error will be reported when the hoverPickEnabled flag enabled HOT 1
- How To Highlight the different portions of wexbim files [Floors,Walls,etc] HOT 5
- Can anyone please verify my code to load Ifc Structure HOT 2
- Reading Proper Spatial Structure of Ifc File HOT 5
- Spatial Structure just reads The Three(3) Lines Then breaks. HOT 6
- Can anyone give me code for structure reading HOT 2
- Convert Ifc To DWG drawing with Xbim Toolkit HOT 4
- Extracting Floor Plans from Ifc File HOT 3
- Can we Convert Ifc to Svg File With XBim Toolkit OR In any otherway HOT 5
- License question HOT 5
- How to reset style of only one object ? HOT 1
- How can I display an IFC file directly using xbim-viewer.js? HOT 3
- How to exchange mouse button events? HOT 1
- After installation how to use it?
- Scrolling for zoom is not working HOT 3
- Integration with a non NPM compatible project HOT 3
- Coloring Element HOT 2
- Archicad IFC wrong behavior in the XbimWebUI HOT 11
- Handling Composite Elements HOT 1
- viewer.getModelState(modelId: number) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xbimwebui.