Giter Club home page Giter Club logo

Comments (3)

jpobst avatar jpobst commented on June 1, 2024 1

Agreed, I was thinking the same thing. 😉

from androidx.

jpobst avatar jpobst commented on June 1, 2024

I suspect anyone who knows why this was written this way is long gone.

However, CustomTabsActivityManager has a public constructor:

public CustomTabsActivityManager (Activity parentActivity)
{
  ParentActivity = parentActivity;
}

You should be able to create whatever CustomTabsActivityManager instances you want and managed their lifetimes however you see fit without using the From method.

from androidx.

koviant avatar koviant commented on June 1, 2024

Thanks, that should work. I guess now I should head out to the MAUI repo and ask them to drop calling the From method in favor of that constructor.

Btw, if you don't mind, I would like make a PR adding an [Obsolete] attribute on the From method, so that in future there would be less chance that someone would use this method, with the message that it may cause a memory leak by holding the reference to the activity in the static instance field.

from androidx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.