Clean source dependency for readability about emqtt5 HOT 6 CLOSED

I think I've solved the issue, please test the latest master branch and report if it's ok for you.

from emqtt5.

Yep. I agree, but it also means that you must add -I/path/to/include/folder to compiler flags. For a library that's being included by others, I think it's a pain to do so. Not sure what is the best to do here.

from emqtt5.

You have already added ${CMAKE_CURRENT_SOURCE_DIR}/include, so only we have to do is change the #include statement. we don't need to add -I/path/to/include/folder any more. If you don't like it, just close the PR without merging to master. It's no problem.

from emqtt5.

No, I meant for those not using cmake, like ESP32. I'll test it tonight and let you know when I'm done.

from emqtt5.

Ah, I see!

from emqtt5.

Thank you very much for your prompt response. I think what I pointed out has been properly corrected. So I close this issue. You don't need to merge #6 at all because it is problematic.

from emqtt5.