Giter Club home page Giter Club logo

Comments (8)

wuhuikai avatar wuhuikai commented on July 30, 2024 1

@TuringsEgo You're right. They removed app from pysc2.lib. I'll write my own app and replace it.

from msc.

wuhuikai avatar wuhuikai commented on July 30, 2024

There isn't a flag min_mmr in parse_replay_info.py but in preprocess.py. We do not need to call FLAGS(sys.argv) explicitly, because app.run() does it.

from msc.

H-Park avatar H-Park commented on July 30, 2024

What version of gflags are you using?

from msc.

wuhuikai avatar wuhuikai commented on July 30, 2024

@TuringsEgo python_gflags == 3.1.1

from msc.

H-Park avatar H-Park commented on July 30, 2024

I think the update of PySC2 is the root of this error. They removed app from pysc2.lib

google-deepmind/pysc2@f2f96c0

Prior to this commit, you are correct in that it called FLAGS(sys.argv) for you.

Are you going support the newest version of PySC2 in the future?

from msc.

milisims avatar milisims commented on July 30, 2024

You can use absl as pysc2 does. The app() calls will need to be given main as an arg, and instead of gflags from absl import flags seems to be working for me. Don't need to write one.

from msc.

wuhuikai avatar wuhuikai commented on July 30, 2024

@matthsims Yes, you're right.

from msc.

wuhuikai avatar wuhuikai commented on July 30, 2024

Solved in #4.

from msc.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.