Installer Improvements about wrye-bash HOT 13 CLOSED

Yea from me - and frankly splitting up is the spirit :)

Insert new lines at the end of new files and trim trailing space please !

On Thu, Feb 20, 2014 at 9:29 AM, WrinklyNinja [email protected]:

Right now the installer script is very long (> 3000 lines), and there are
a few things that I think it could do better. I'm proposing the following:

Split the installer script into several files, using includes. I
suggest one file for the installer bit, one for the uninstaller, one for
the custom pages, and another for tying them together with the rest of the
scripting (vars, helper functions, definitions, etc.).
2.

Combine the requirement part with the "components" part - so where
there's the checklist with entries for Bash and the Start menu shortcuts,
also have a read-only checkbox for prerequisites. Not only does this
simplify the code and streamline installation, it also means we can better
log the process in the details box that is present during the actual
installation part.

@Wrye-Bashers https://github.com/Wrye-Bashers: I'd like to get this
done ASAP, if there are no objections, so please yea/nea ASAP too.

Reply to this email directly or view it on GitHubhttps://github.com//issues/17
.

from wrye-bash.

NSIS isn't my cup of soup, but yeah, splitting it up as logically as it can be makes the most sense.
Smaller portions are easier to swallow anyway.
As long as it doesn't break the 30000+ lines bash record for longest amount of lines in a file, I'm cool :) Go for it.

from wrye-bash.

I'm all for it.

Are there any window properties in the NSIS script that can be adjusted or might be missing? My son got this screen after the first Python dependency was installed. So once it installed all 4 of them, he was not able to click 'next' to continue with the install. When we ran the installer again it recognized the dependencies were installed and just continued from that point.

from wrye-bash.

OK, I made some changes to how the installer handles requirements in 90f17f9. I've uploaded an installer built from the updated script here, if people could test it, that would be great. It all works for me (now - I've updated this message a few times when I noticed bugs).

A bonus change was that the MSVC 2008 redist that is required for the standalone Bash should be downloaded and installed just like the 2013 redist is - I'm not sure why that wasn't done already, but it's in now.

Note that this isn't the final 304.4 installer, just a test..

from wrye-bash.

Another improvement I thought of: currently the Bash installer will clean up files from old installs. We could change this so that the installer first checks for an existing Bash install and runs that to uninstall such files, before continuing with its own install.

from wrye-bash.

@lojack5: I've been going through the Wrye Bash thread OPs, and noticed for the first time that Bash apparently needs a MSVC 2005 package on Windows XP. This isn't handled at all by the installer, or mentioned anywhere in the readmes - should I add this info, or is it outdated/incorrect?

from wrye-bash.

Yes, If I recall correctly it had to do with some changes I think Lojack had done at the time, a few years back. Don't recall exactly what it was for, but I do recall one of the 2005 packages was needed for it to fully work right with XP. Might have been for the wizards... It was detailed in a post somewhere and Wrinkly had a small bit in the updated readme(was being worked on at the time) at the time about this one oddball req for xp users. I don't recall the readme part went into full detail tho or it maybe didn't get worked into the installer.

from wrye-bash.

and Wrinkly had a small bit in the updated readme

I don't recall writing that, and it doesn't appear to be in the readme now, if it was.

Well, if it is correct info, I can add it, and update the installer.

from wrye-bash.

Hmmm cant seem to find it in the old readme. maybe it was a mockup version I was writing, before you decided to just do a full blown rewrite.

This is the only thing close I can find about it in the old readme

 If you choose to install the Standalone version (default), this will check for the required MSVC Runtime. If missing, it will prompt you to allow it to download and install the missing dependancy.

The answer is probably floating in a post or PM somewhere. Lojack may recall better than I. It wasn't a real big issue. There was a link to the correct installer wherever that was. I believe I had the wrong one installed at the time.

This is the one I have archived in my Install Files backups
Microsoft Visual C++ 2005 SP1 Redistributable Package (x86) ATL Security Update

from wrye-bash.

Yes, the standalone needs the 2005 redist, because Python is built against that. When you run from Python files you don't need it obviously because Python has it packaged with it.

from wrye-bash.

Yes, the standalone needs the 2005 redist

Everywhere I've seen says it needs the 2008 redist - the 2005 redist is something different. I can update the readmes to say that XP users need the 2005 one, and update the installer to try installing it if the user is running XP (checking to see if it's already there is pretty dodgy, so it's better just to run the installer).

from wrye-bash.

I may be confused. I'll have to figure out it when I get home then.

Edit: Found it - 7zUnicode.exe was built against the 2005 runtime. Vista+ comes with that, so only XP users have to manually install it.

from wrye-bash.

OK, I've done everything I wanted as of ad595c8, so closing this.

from wrye-bash.