Add SPEED paramter to Rainbow about rogauracore HOT 6 OPEN

The pull request I opened allows for optional arguments, but it uses a different protocol for the rainbow instruction. You could backport it to use the old rainbow instruction, but keep the optional speed argument.

from rogauracore.

Hey Josh,
Thanks for the quick response.

I tried backporting and running it, but when I execute $ make, it threw some errors.

src/rogauracore.c:278:52: error: initializer element is not constant
{"single_breathing", &single_breathing, 2, 1, {SPEED}},

src/rogauracore.c:278:52: note: (near initialization for ‘FUNCTION_RECORDS[1].scalars[0]’)
src/rogauracore.c:279:54: error: initializer element is not constant
{"single_colorcycle", &single_colorcycle, 0, 1, {SPEED}},

src/rogauracore.c:279:54: note: (near initialization for ‘FUNCTION_RECORDS[2].scalars[0]’)
src/rogauracore.c:281:50: error: initializer element is not constant
{"multi_breathing", &multi_breathing, 4, 1, {SPEED}},

src/rogauracore.c:281:50: note: (near initialization for ‘FUNCTION_RECORDS[4].scalars[0]’)
src/rogauracore.c:291:44: error: initializer element is not constant
{"brightness", &set_brightness, 0, 1, {BRIGHTNESS}},

src/rogauracore.c:291:44: note: (near initialization for ‘FUNCTION_RECORDS[14].scalars[0]’)

Makefile:395: recipe for target 'src/rogauracore.o' failed
make[1]: *** [src/rogauracore.o] Error 1

From this thread, I figured out that declaring const over here is generating errors.

const ScalarDef SPEED = { "SPEED", "speed", 1, 3 };
const ScalarDef BRIGHTNESS = { "BRIGHTNESS", "brightness", 0, 3 };

How do I fix this?

from rogauracore.

Oh, I thought I patched that. I might still have local changes; I'll have to check later. The fix looks like what I did in #32.

from rogauracore.

Yes, replacing const with #define fixed it.
I've made a pull request, do check it. Now it compiles without any errors.
But still, I am not able to figure out how to add the speed parameter alongside rainbow.
I executed

$ sudo rogauracore rainbow 2

and I'm getting Function rainbow takes no arguments.
Is this the right command?

from rogauracore.

My master branch is behind wroberts', so the fix still applied to it, but the branch you wanted to edit was retool. But if the rainbow command Will is using works for you, the one I'm using likely will not. You'd need to plug the old rainbow code into it, as well, right around line 298.

From the looks of things, that branch should already build, as-is.

from rogauracore.

Okay. I'll try the old rainbow code.

Thanks!

from rogauracore.