Giter Club home page Giter Club logo

Comments (3)

franz-josef-kaiser avatar franz-josef-kaiser commented on August 15, 2024

@funkedgeek One thing I haven't had time for so far is testing the filters and action. Would you mind writing a short test snippet (gist) that test all the filters and actions? I guess there's more wrong than one. Thanks!

from meta-box.

funkatron82 avatar funkatron82 commented on August 15, 2024

Well, the main issue I'm finding is this: line 204 of meta-box.php already pulls the the end_html function of the check box field class, so line 16 of the check box field class is redundant and makes the end_html function get called twice. Further more, when the filter at line 16 of the check box field class get called, it passes the arguments wrong somehow. $meta gets passed as $field and instead of showing the description of the field, it shows the meta. The issue isn't always reproducibly:sometimes the description works and sometimes I get either 0 or 1, dependent on how the the check box was saved. An example: http://www.watchonepiecelegally.com/broken_checkbox.jpg

from meta-box.

rilwis avatar rilwis commented on August 15, 2024

Ah, nice. Thanks for your commit. I added the end_html() call in the main meta-box.php file, but didn't remove the filter in field class :)

from meta-box.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.