Giter Club home page Giter Club logo

Comments (5)

wperkins avatar wperkins commented on August 20, 2024

This is nearly complete. The only thing left are diagonal operations (extraction, add, multiply, etc.).

from gridpack.

wperkins avatar wperkins commented on August 20, 2024

Some MatrixT<> methods for complex value manipulation are not correct: real(), imaginary(), conjugate(). These should not work with a real-valued PETSc. Review unit tests to make sure these are tested.
Also, there is a similar problem with MatrixT<>::norm2().

from gridpack.

wperkins avatar wperkins commented on August 20, 2024

I think the only thing left is an implementation of MatrixT<>::scale() for complex matrices based on a real-valued library. I could not figure out a way to implement this at a high level (fallback namespace). It will probably have to be done at a pretty low level. An exception is thrown if MatrixT<ComplexType>::scale() is called when the underlying library is real-valued.

from gridpack.

wperkins avatar wperkins commented on August 20, 2024

I need to re-open this because there are several complex matrix methods not yet implemented for a real-based library: real(), imaginary(), and conjugate() (maybe others). Apparently, these need better unit tests too. These methods should be implemented using the operator strategy used by the vector implementation, but using MatGetRow() is in PETScMatrixImplementation<>::p_scale().

from gridpack.

wperkins avatar wperkins commented on August 20, 2024

I think this is done (again).

from gridpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.