PHP i18n functions prefixed with a slash are ignored about i18n-command HOT 11 CLOSED

In any case, it needs a volunteer to submit a PR to the Gettext library to help fix this properly :)

I have come up with a fix and opened a PR:

• php-gettext/Gettext#288

I don't have much experience with this, but I did my best to contribute.

from i18n-command.

Well that is surprising!

Looks like the PHP functions scanner we're using doesn't properly extract such functions call, so unfortunately this will need to get fixed upstream.

from i18n-command.

Just adding a note here that this isn't likely to be fixed in the Gettext repo any time soon due to time constraints; incase anyone from the wp-cli team is able to pick this up.

php-gettext/Gettext#284 (comment)

from i18n-command.

It might be good to know that this seems to work well on PHP 7.4, but it goes wrong in PHP 8.

• Test on PHP 7.4 → remcotolsma/wp-cli-i18n-make-pot-issue-php-8@41f1280
• Test on PHP 8.1 → remcotolsma/wp-cli-i18n-make-pot-issue-php-8@e89b029

A workaround is to run wp i18n make-pot on PHP 7.4:

brew link --overwrite [email protected]

from i18n-command.

Awesome, thanks a lot! And it has been merged, too!

Once a new release of Gettext v4 has been released, we can update the dependency here & update our tests too. Then we should be all set.

from i18n-command.

Working on adding a test here: #344

Updating the dependency here:

• wp-cli/wp-cli-bundle#466

from i18n-command.

Maybe it's related to a token_get_all() change in PHP 8:
https://3v4l.org/48MdV

In PHP 7.4 the function call \__ is split in two tokens \ and __ in PHP 8.0 it's just one token \__.

In PHP 8.0 there is a new T_NAME_FULLY_QUALIFIED token:
https://www.php.net/manual/en/tokens.php

It could be fixed by adding T_NAME_FULLY_QUALIFIED to the following line:
https://github.com/php-gettext/Gettext/blob/207719c6eae36f5ac7c2c9542f6a4d4b76307e5a/src/Utils/PhpFunctionsScanner.php#L101

And by adding fully qualified function names (\__, \_e, etc.) to this list:

from i18n-command.

Interesting, yeah that might be it. In any case, it needs a volunteer to submit a PR to the Gettext library to help fix this properly :)

from i18n-command.

The https://github.com/php-gettext/Gettext library is already moved on the version 5 and the new https://github.com/php-gettext/PHP-Scanner library uses https://github.com/nikic/php-parser. It is quite possible that https://github.com/nikic/php-parser has better support for fully qualified names (FQN) and the problem is therefore no longer an issue in the latest Gettext library?

from i18n-command.

Yes it's quite possible, but we cannot use the newer version yet because of PHP version requirements.

from i18n-command.

ℹ️ Version 4.8.8 of gettext/gettext was released yesterday: https://github.com/php-gettext/Gettext/releases/tag/v4.8.8 🎉.

from i18n-command.